From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Sat, 24 Feb 2007 06:48:22 +0100 Subject: [U-Boot-Users] rtc/ds1374.c turns clock OFF when it means to turn it ON In-Reply-To: References: Message-ID: <200702240648.22603.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Andrew, On Friday 23 February 2007 22:57, Andrew Klossner wrote: > rtc/ds1374.c mistakes the "don't enable the oscillator" bit for a > "do enable the oscillator bit" and sets it to 1, stopping the clock. > My guess is that nobody has actually used rtc_set or rtc_reset > with this driver. A quick look shows that this driver is used by the Freescale MPC8349EMDS & MPC8360EMDS board ports. Some of the Freescale guys (Kim?) should jump in here. > We've been using this chip for a few years with a proprietary OS > and are now switching to u-boot and Linux. I revised the u-boot > driver based on our stable driver. Besides fixing the oscillator bit, > I set it up to read all the registers with a single IIC transaction > for efficiency and to see any error code from the IIC subsystem. > > I would attach the new driver here but I can't figure out how. > I'm typing through a broken "hello new user, we don't yet trust you" > web page. If somebody could send instructions to > andrew at cesa.opbu.xerox.com, I'd like to submit this revision. For submitting patches please take a look at the section "Submitting Patches:" at the end of the README file. Nowadays patches created using git are even better (like in the Linux kernel development). Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany =====================================================================