From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] arm SoC code in U-Boot.
Date: Wed, 7 Mar 2007 07:30:29 +0100 [thread overview]
Message-ID: <200703070730.30835.sr@denx.de> (raw)
In-Reply-To: <010201c76041$9a42fa90$01c4af0a@Glamdring>
On Tuesday 06 March 2007 23:45, Ulf Samuelsson wrote:
> > When adding "cpu/freescale/" I see no clear line what should go in
> > there and what not. Whould we then move all the cpu/mpc???/
> > directories into cpu/freescale/ ? And then probably create (for
> > consistency) a "cpu/amcc/" directory and mode cpu/ppc4xx into that
> > one? What do we get in addition to another directory level? IMO that
> > would not improve anything, and you still don't see where shared code
> > is located.
>
> I think you can still keep the cpu/ppc4xx directory but if you
> find that cpu/ppcYYY has shared code with the cpu/ppc4xx
> and you would like to have a common driver, then
> you put it in "cpu/amcc/ppc.
>
> For freescale you would put shared code in
> cpu/freescale/imx and cpu/freescale/ppc
> and maybe cpu/freescale/coldfire
I still think that this code we are talking about here, is most likely some
driver code for some ethernet controller, or a I2C controller etc. I would
like to "collect" this sort of driver code, even if it's SoC driver code,
under the "drivers" directory. This is already done for some drivers but it's
not done consistently. We already have:
drivers/qe/*
drivers/netarm_eth.*
drivers/omap1510_i2c.*
...
Why not try to match this a little more to the Linux directory structure:
drivers/net/netarm_eth.*
drivers/net/qe/*
drivers/i2c/omap1510_i2c.*
...
From my understanding the drivers mentioned above will fit in here much better
than in some cpu directories. Just my 0.02$.
BTW: I know it's always a problem to "move" code in a version control system
because of the revision history.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
=====================================================================
next prev parent reply other threads:[~2007-03-07 6:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 17:02 [U-Boot-Users] arm SoC code in U-Boot Peter Pearse
2007-03-06 21:36 ` Wolfgang Denk
2007-03-06 21:55 ` Ulf Samuelsson
2007-03-06 22:32 ` Wolfgang Denk
2007-03-06 22:45 ` Ulf Samuelsson
2007-03-06 23:51 ` [U-Boot-Users] SDRAM cache inhibit David Clark
2007-03-07 0:06 ` Wolfgang Denk
2007-03-07 15:35 ` David Clark
2007-03-07 6:30 ` Stefan Roese [this message]
2007-03-07 12:37 ` [U-Boot-Users] arm SoC code in U-Boot Haavard Skinnemoen
2007-03-07 14:27 ` Ben Warren
2007-03-07 14:39 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2007-03-08 8:17 TXEMA LOPEZ
2007-03-08 8:40 ` Wolfgang Denk
2007-03-02 10:03 Txema Lopez
2007-03-05 11:38 ` Ulf Samuelsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703070730.30835.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox