From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Antw: Re: [PATCH] Add first Netstal board HCU4
Date: Tue, 10 Apr 2007 08:55:57 +0200 [thread overview]
Message-ID: <200704100855.58191.sr@denx.de> (raw)
In-Reply-To: <20070406193927.D1925352650@atlas.denx.de>
On Friday 06 April 2007 21:39, Wolfgang Denk wrote:
> in message <ev5roc$qoo$1@sea.gmane.org> you wrote:
> > Here my reworked patch. Tried a follow all of your comments.
>
> There are some coding style violations: indentation not by TAB.
>
> Please write comments in English language, thanks.
>
> include/configs/hcu4.h is formatted in a way that makes it mostly
> unreadable. You may want to clean this up a bit.
>
> You use a private flash driver for something that looks as if it was
> CFI compatible - why don't you use the CFI driver?
This has been discussed before (I asked the same question). IIRC the board
used an 8bit wide non CFI-compatible FLASH and an 16bit wide CFI compatible
FLASH device. With the current CFI implementation this setup is not supported
so a "custom" driver has to be used.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
=====================================================================
next prev parent reply other threads:[~2007-04-10 6:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 20:37 [U-Boot-Users] [PATCH] Add first Netstal board HCU4 Niklaus Giger
2007-02-10 7:59 ` Stefan Roese
2007-02-10 9:01 ` Niklaus Giger
2007-02-10 19:15 ` Stefan Roese
2007-02-12 18:13 ` [U-Boot-Users] Antw: " Niklaus Giger
2007-02-12 19:25 ` Stefan Roese
2007-02-14 17:10 ` Niklaus Giger
2007-04-04 15:30 ` Stefan Roese
2007-04-06 16:16 ` Niklaus Giger
2007-04-06 16:58 ` Stefan Roese
2007-04-06 19:31 ` Wolfgang Denk
2007-04-06 19:39 ` Wolfgang Denk
2007-04-10 6:55 ` Stefan Roese [this message]
2007-04-10 8:30 ` Stefan Roese
2007-04-04 15:40 ` [U-Boot-Users] " Stefan Roese
2007-04-06 16:22 ` Niklaus Giger
2007-04-10 12:36 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704100855.58191.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox