From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 10 Apr 2007 14:36:05 +0200
Subject: [U-Boot-Users] [PATCH] Add first Netstal board HCU4
In-Reply-To: <ev5s44$qoo$2@sea.gmane.org>
References: <200702092137.23677.niklaus.giger@member.fsf.org>
	<200704041740.00521.sr@denx.de> <ev5s44$qoo$2@sea.gmane.org>
Message-ID: <200704101436.06185.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Niklaus,

On Friday 06 April 2007 18:22, Niklaus Giger wrote:
> Here it is. bzipped because of the size limitation. I reworked it
> slightly and tried harder to follow the Linux kernel coding style.

Thanks. That's good. But unfortunately you had to gzip it because
of the size limitation. This would not have been necessary if you
had split your patch up into 2 or 3 mails. I would recommend something
like:

[PATCH 1/3]: ppc4xx: Add Netstal common board directory
[PATCH 2/3]: ppc4xx: Add Netstal HCU4 board support
[PATCH 3/3]: ppc4xx: Add Netstal HCU4 board config file

In-line patches make my reviewing easier. Thanks.
 
> I used the following commands for my workflow (Could not find a clear
> entry in the WiKi for a simple example tailored to the u-boot).
> 
> $ git clone http://source.denx.net/git/u-boot.git u-boot.git
> $ cd u-boot.git
> 
> Then I added the following lines to .git/config
> >[user]
> >name???=???????"Niklaus Giger"
> >email??=???????"niklaus.giger at netstal.com"
> 
> <added/edited some files>
> $ git add <for each new directory or file>
> Used "git status" to check whether I added all new files correcty.
> Used "git diff origin --check" to look for trailing/superfluous
> whitespaces.
> Used "git diff origin -p --summary origin" to preview my changes.
> Once I was satisfied, I preceeded with
> $ git-commit --all --signoff -m "Add first Netstal board HCU4: Second
> try"

Please add a little more descriptive commit message: Like which CPU
is used.

> $ git-format-patch origin
> $ mv 0001-Add-first-Netstal-board-HCU4-Second-try.patch \
>   Add-first-Netstal-board-HCU4-Second-try.patch
> $ gzip Add-first-Netstal-board-HCU4-Second-try.patch
> 
> Is this a good workflow?

I'm still using cogito, so I can't really comment on the core git
usage.

Please clean up the issues Wolfgang addressed and resubmit. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================