public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Denis Peter <d.peter@mpl.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers
Date: Fri, 13 Apr 2007 08:45:32 +0200	[thread overview]
Message-ID: <200704130845.32830.d.peter@mpl.ch> (raw)
In-Reply-To: <200704130756.11280.sr@denx.de>

Hello Stefan,

On Friday 13 April 2007 07:56, Stefan Roese wrote:
> Hi Denis,
> 
> On Thursday 12 April 2007 22:27, Grant Likely wrote:
> > On 4/12/07, Greg Lopp <lopp@pobox.com> wrote:
> > > Signed-off-by: Greg Lopp <lopp@pobox.com>
> >
> > Acked-by: Grant Likely <grant.likely@secretlab.ca>
> >
> > Stefan, can you pick this one up please?
> 
> Yes I will. Just checking with an older patch that tried to fix this issue:
> 
> Denis, could you please take a look at this patch and let me know if this 
> patch supersedes your patch:
> 
> "Re: [U-Boot-Users] [PATCH] Fix bugs in cmd_ide.c and cmd_scsi.c"
> 
> from April, 2nd?
> 

My patch from April, 2nd, fixes this issue already. In my patch I decided to just 
cast the pointer back to ulong *, since I don't know if it is a good idea to increment 
a pointer to void *. 
But the same bug is also in cmd_scsi.c which also fixed by my patch. The other bug
which prevented to use the command "diskboot" and "scsiboot" from other devices than
device 0, is also fixed by my patch.
It seems that the function atapi_read slipped my attention, this function is not fixed 
by my patch.

With best regards,

Denis

  reply	other threads:[~2007-04-13  6:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-12 15:28 [U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers Greg Lopp
2007-04-12 16:33 ` Grant Likely
2007-04-12 19:07   ` Greg Lopp
2007-04-12 19:49     ` Grant Likely
2007-04-12 20:03       ` Greg Lopp
     [not found]         ` <1176408946.14027.41.camel@saruman.qstreams.net>
2007-04-12 20:25           ` Grant Likely
2007-04-12 20:27         ` Grant Likely
2007-04-13  5:56           ` Stefan Roese
2007-04-13  6:45             ` Denis Peter [this message]
2007-04-13  6:54               ` Grant Likely
2007-04-13  7:18                 ` Stefan Roese
2007-04-13 11:19                   ` Denis Peter
2007-04-13 17:22               ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704130845.32830.d.peter@mpl.ch \
    --to=d.peter@mpl.ch \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox