From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 13 Apr 2007 09:18:41 +0200 Subject: [U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers In-Reply-To: <528646bc0704122354k24467ee6oc1951b46e32df1df@mail.gmail.com> References: <200704130845.32830.d.peter@mpl.ch> <528646bc0704122354k24467ee6oc1951b46e32df1df@mail.gmail.com> Message-ID: <200704130918.42688.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi All, On Friday 13 April 2007 08:54, Grant Likely wrote: > > > Denis, could you please take a look at this patch and let me know if > > > this patch supersedes your patch: > > > > > > "Re: [U-Boot-Users] [PATCH] Fix bugs in cmd_ide.c and cmd_scsi.c" > > > > > > from April, 2nd? > > > > My patch from April, 2nd, fixes this issue already. In my patch I decided > > to just cast the pointer back to ulong *, since I don't know if it is a > > good idea to increment a pointer to void *. > > Incrementing a void* is safe. > > Personally, I prefer the solution in Greg's patch. I appied Greg's patch and the device# part of Denis's patch to my u-boot-ppc4xx repository. Please give it a try and let me know if the issues are fixed now: git://www.denx.de/git/u-boot-ppc4xx.git Then I'll ask Wolfgang to pull from my repository. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany =====================================================================