From: Rodolfo Giometti <giometti@enneenne.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] VIDEO_FB_LITTLE_ENDIAN name confusion
Date: Tue, 17 Apr 2007 22:46:41 +0200 [thread overview]
Message-ID: <20070417204641.GA23698@enneenne.com> (raw)
In-Reply-To: <c166aa9f0704161009w5b632cfbk5fc70949171ffdb7@mail.gmail.com>
On Mon, Apr 16, 2007 at 12:09:14PM -0500, Andrew Dyer wrote:
> I've noticed that VIDEO_FB_LITTLE_ENDIAN in drivers/cfb_console.c is
> not really well named. What it does is swap bytes around if the frame
> buffer has a /different/ endianness from the host. If you start with
> a little endian host and frame buffer and define
> VIDEO_FB_LITTLE_ENDIAN the drawn colors get incorrectly byte swapped.
I think that the right thing to do is to avoid that the byte are
swapped if the CPU and framebuffer endianess are the same.
However the patchg reduces possible misunderstanding...
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti at enneenne.com
Linux Device Driver giometti at gnudd.com
Embedded Systems giometti at linux.it
UNIX programming phone: +39 349 2432127
prev parent reply other threads:[~2007-04-17 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 17:09 [U-Boot-Users] [PATCH] VIDEO_FB_LITTLE_ENDIAN name confusion Andrew Dyer
2007-04-17 20:46 ` Rodolfo Giometti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417204641.GA23698@enneenne.com \
--to=giometti@enneenne.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox