From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodolfo Giometti Date: Tue, 17 Apr 2007 22:46:41 +0200 Subject: [U-Boot-Users] [PATCH] VIDEO_FB_LITTLE_ENDIAN name confusion In-Reply-To: References: Message-ID: <20070417204641.GA23698@enneenne.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Apr 16, 2007 at 12:09:14PM -0500, Andrew Dyer wrote: > I've noticed that VIDEO_FB_LITTLE_ENDIAN in drivers/cfb_console.c is > not really well named. What it does is swap bytes around if the frame > buffer has a /different/ endianness from the host. If you start with > a little endian host and frame buffer and define > VIDEO_FB_LITTLE_ENDIAN the drawn colors get incorrectly byte swapped. I think that the right thing to do is to avoid that the byte are swapped if the CPU and framebuffer endianess are the same. However the patchg reduces possible misunderstanding... Ciao, Rodolfo -- GNU/Linux Solutions e-mail: giometti at enneenne.com Linux Device Driver giometti at gnudd.com Embedded Systems giometti at linux.it UNIX programming phone: +39 349 2432127