public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nikita V. Youshchenko <yoush@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT
Date: Wed, 23 May 2007 12:45:19 +0400	[thread overview]
Message-ID: <200705231245.24522@sercond.localdomain> (raw)

Current include/configs/MPC8349ITX.h does contain some support for building
image that will be started from memory (without putting in into flash).
It could be triggered by building with TEXT_BASE set to a low value.

However, this support is incomplete: using of low TEXT_BASE causes
defining configuration macros in inconsistent way, which later leads
to compilation errors. In particular. flash support is being disabled,
but then flash structures get referenced.

This patch fixes this, making it possible to build with low TEXT_BASE.

Signed-Off-By: Nikita Youshchenko <yoush@debian.org>

--- a/include/configs/MPC8349ITX.h
+++ b/include/configs/MPC8349ITX.h
@@ -408,6 +409,7 @@ boards, we say we have two, but don't di
   #define CFG_ENV_SIZE         0x2000
 #else
   #define CFG_NO_FLASH         /* Flash is not usable now */
+  #undef CFG_FLASH_CFI_DRIVER
   #define CFG_ENV_IS_NOWHERE   /* Store ENV in memory only */
   #define CFG_ENV_ADDR         (CFG_MONITOR_BASE - 0x1000)
   #define CFG_ENV_SIZE         0x2000
@@ -436,7 +438,14 @@ boards, we say we have two, but don't di
 #define CONFIG_COMMANDS_I2C    0
 #endif

-#define CONFIG_COMMANDS                (CONFIG_CMD_DFL | \
+#ifdef CFG_NO_FLASH
+#define CONFIG_COMMANDS_DEFAULT (CONFIG_CMD_DFL & ~(CFG_CMD_FLASH | \
+                                                   CFG_CMD_IMLS))
+#else
+#define CONFIG_COMMANDS_DEFAULT CONFIG_CMD_DFL
+#endif
+
+#define CONFIG_COMMANDS                (CONFIG_COMMANDS_DEFAULT | \
                                CONFIG_COMMANDS_CF      | \
                                CFG_CMD_NET     | \
                                CFG_CMD_PING    | \

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070523/fa9f208f/attachment.pgp 

             reply	other threads:[~2007-05-23  8:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23  8:45 Nikita V. Youshchenko [this message]
2007-05-23 15:09 ` [U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT Timur Tabi
2007-05-23 15:37   ` Nikita V. Youshchenko
2007-05-23 15:55     ` Timur Tabi
2007-05-23 16:30       ` Wolfgang Denk
2007-05-23 16:50         ` Timur Tabi
2007-05-23 16:52 ` Timur Tabi
2007-05-23 18:59   ` Nikita V. Youshchenko
2007-05-23 19:08     ` Timur Tabi
2007-05-23 17:48 ` Timur Tabi
2007-05-23 18:38   ` Wolfgang Denk
2007-05-23 18:43     ` Timur Tabi
2007-05-23 19:51       ` Wolfgang Denk
2007-05-23 20:01         ` Nikita V. Youshchenko
2007-05-23 20:13         ` Nikita V. Youshchenko
2007-05-23 23:11           ` Wolfgang Denk
2007-05-24  8:10             ` Nikita V. Youshchenko
2007-05-24 12:36               ` Wolfgang Denk
2007-05-24 12:49                 ` Jerry Van Baren
2007-05-24 15:25                 ` Timur Tabi
2007-05-24 18:36                 ` Jon Loeliger
2007-05-24 18:38                   ` Timur Tabi
2007-05-24 19:43                   ` Wolfgang Grandegger
2007-05-24 12:39               ` Wolfgang Grandegger
2007-05-23 20:29         ` Timur Tabi
2007-06-01 20:18 ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705231245.24522@sercond.localdomain \
    --to=yoush@debian.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox