[U-Boot-Users] [PATCH] LOGO: Allow define "LOGO_BMP" to be globally defined.

Wolfgang Denk
2007-05-25T14:29:13Z

In message <20070525142054.GE4199@enneenne.com> you wrote:
> This allow developers to define per board logo file into main configuration
> file as follow:
>
> wwpc1100_config : unconfig
> @$(MKCONFIG) $(@:_config=) arm pxa wwpc1100
> @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mk

I don't like this. This adds configuration information into Makefile,
where it does not belong.

Please don't do this.

> --- a/Makefile
> +++ b/Makefile
> @@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk))
...
> @@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc)
> CROSS_COMPILE = powerpc-linux-
> endif
> ifeq ($(ARCH),arm)
> -CROSS_COMPILE = arm-eurotech-linux-
^^^^^^^^^^^^^^^^^^^ What's that?
> +CROSS_COMPILE = arm-linux-

Also, this patch does not apply.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Just think of a computer as hardware you can program."
- Nigel de la Tierre