From: Rodolfo Giometti <giometti@enneenne.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] LOGO: Allow define "LOGO_BMP" to be globally defined.
Date: Fri, 25 May 2007 16:54:13 +0200 [thread overview]
Message-ID: <20070525145413.GG21180@enneenne.com> (raw)
In-Reply-To: <20070525142913.0675C352B1F@atlas.denx.de>
On Fri, May 25, 2007 at 04:29:13PM +0200, Wolfgang Denk wrote:
> In message <20070525142054.GE4199@enneenne.com> you wrote:
> > This allow developers to define per board logo file into main configuration
> > file as follow:
> >
> > wwpc1100_config : unconfig
> > @$(MKCONFIG) $(@:_config=) arm pxa wwpc1100
> > @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mk
>
> I don't like this. This adds configuration information into Makefile,
> where it does not belong.
>
> Please don't do this.
So where should I add this info?
>
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk))
> ...
> > @@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc)
> > CROSS_COMPILE = powerpc-linux-
> > endif
> > ifeq ($(ARCH),arm)
> > -CROSS_COMPILE = arm-eurotech-linux-
> ^^^^^^^^^^^^^^^^^^^ What's that?
> > +CROSS_COMPILE = arm-linux-
>
> Also, this patch does not apply.
Ooops! Sorry, that was my fault... :'(
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti at enneenne.com
Linux Device Driver giometti at gnudd.com
Embedded Systems giometti at linux.it
UNIX programming phone: +39 349 2432127
next prev parent reply other threads:[~2007-05-25 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 14:20 [U-Boot-Users] [PATCH] LOGO: Allow define "LOGO_BMP" to be globally defined Rodolfo Giometti
2007-05-25 14:29 ` Wolfgang Denk
2007-05-25 14:54 ` Rodolfo Giometti [this message]
2007-05-25 15:43 ` Wolfgang Denk
2007-05-25 16:15 ` Rodolfo Giometti
2007-05-25 16:48 ` Wolfgang Denk
2007-05-26 13:12 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525145413.GG21180@enneenne.com \
--to=giometti@enneenne.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox