[U-Boot-Users] [PATCH] LOGO: All logos must be placed into the "logos" directory.

[U-Boot-Users] [PATCH] LOGO: All logos must be placed into the "logos" directory.

[Rodolfo Giometti]

Signed-off-by: Rodolfo Giometti <giometti@linux.it>
---
 tools/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index 6177f90..14eedf0 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -40,7 +40,7 @@ endif
 LOGO_H	= $(OBJTREE)/include/bmp_logo.h
 
 ifeq ($(LOGO_BMP),)
-LOGO_BMP= logos/denx.bmp
+LOGO_BMP= denx.bmp
 endif
 
 #-------------------------------------------------------------------------
@@ -203,8 +203,8 @@ $(obj)crc32.c:
 		@rm -f $(obj)crc32.c
 		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
 
-$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
-		$(obj)./bmp_logo $(LOGO_BMP) >$@
+$(LOGO_H):	$(obj)bmp_logo logos/$(LOGO_BMP)
+		$(obj)./bmp_logo logos/$(LOGO_BMP) >$@
 
 #########################################################################
 
-- 
1.5.1.1

[U-Boot-Users] [PATCH] LOGO: All logos must be placed into the "logos" directory.

[Wolfgang Denk]

In message <20070525142001.GD4199@enneenne.com> you wrote:
>
> Subject: ... All logos must be placed into the "logos" directory.

Why?

>  ifeq ($(LOGO_BMP),)
> -LOGO_BMP= logos/denx.bmp
> +LOGO_BMP= denx.bmp

Which problem is this supposed to fix? I don't see any advantage, but
I see the disadvantage that with your patch you cannot chose to place
your logo - say - in board/.../ any more.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Landing: a controlled mid-air collision with a planet.

[U-Boot-Users] [PATCH] LOGO: All logos must be placed into the "logos" directory.

[Rodolfo Giometti]

On Fri, May 25, 2007 at 04:26:04PM +0200, Wolfgang Denk wrote:
> In message <20070525142001.GD4199@enneenne.com> you wrote:
> >
> > Subject: ... All logos must be placed into the "logos" directory.
> 
> Why?
> 
> >  ifeq ($(LOGO_BMP),)
> > -LOGO_BMP= logos/denx.bmp
> > +LOGO_BMP= denx.bmp
> 
> Which problem is this supposed to fix? I don't see any advantage, but
> I see the disadvantage that with your patch you cannot chose to place
> your logo - say - in board/.../ any more.

I don't want to fix any problem, I just wish to define some
standards... doing like this I force all logo files to be inside
tools/logos directory.

Currently logos are supposed to be under tools directory which is not
the proper place for them:

   $(LOGO_H):      $(obj)bmp_logo logos/$(LOGO_BMP)
                   $(obj)./bmp_logo logos/$(LOGO_BMP) >$@

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127

[U-Boot-Users] [PATCH] LOGO: All logos must be placed into the "logos" directory.

[Wolfgang Denk]

In message <20070525145246.GF21180@enneenne.com> you wrote:
>
> I don't want to fix any problem, I just wish to define some
> standards... doing like this I force all logo files to be inside
> tools/logos directory.

Why would you want to do that? Unix  philosophy  is  *not*  enforcing
users  to  to  certain  things,  but let users decide what's good for
them.

> Currently logos are supposed to be under tools directory which is not
> the proper place for them:
> 
>    $(LOGO_H):      $(obj)bmp_logo logos/$(LOGO_BMP)
>                    $(obj)./bmp_logo logos/$(LOGO_BMP) >$@

The current code uses LOGO_BMP and defines a default value for it
(logos/denx.bmp); it gives the user the freedom to overwrite this
default.  This is a good thing.

I don't want to lose  that  freedom,  especially  not  when  the  new
situation brings no advantages.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As in certain cults it is possible to kill a process if you know  its
true name.                      -- Ken Thompson and Dennis M. Ritchie

[U-Boot-Users] [PATCH] LOGO: All logos must be placed into the "logos" directory.

[Rodolfo Giometti]

On Fri, May 25, 2007 at 05:43:05PM +0200, Wolfgang Denk wrote:
> 
> The current code uses LOGO_BMP and defines a default value for it
> (logos/denx.bmp); it gives the user the freedom to overwrite this
> default.  This is a good thing.
> 
> I don't want to lose  that  freedom,  especially  not  when  the  new
> situation brings no advantages.

Ok, so what should I do to allow developers to define their preferred
logos?

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127

[U-Boot-Users] [PATCH] LOGO: Allow each board to define its own logo.

[Rodolfo Giometti]

This allow developers to define per board logo file into boards' main
configuration file (board/*/config.mk) as follow:

	# The logo bitmap
	LOGO_BMP = board/<name>/<logo>.bmp

Signed-off-by: Rodolfo Giometti <giometti@linux.it>
---
 tools/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index 6177f90..ad2824d 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -40,7 +40,7 @@ endif
 LOGO_H	= $(OBJTREE)/include/bmp_logo.h
 
 ifeq ($(LOGO_BMP),)
-LOGO_BMP= logos/denx.bmp
+LOGO_BMP= tools/logos/denx.bmp
 endif
 
 #-------------------------------------------------------------------------
@@ -203,8 +203,8 @@ $(obj)crc32.c:
 		@rm -f $(obj)crc32.c
 		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
 
-$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
-		$(obj)./bmp_logo $(LOGO_BMP) >$@
+$(LOGO_H):	$(obj)bmp_logo $(TOPDIR)/$(LOGO_BMP)
+		$(obj)./bmp_logo $(TOPDIR)/$(LOGO_BMP) >$@
 
 #########################################################################
 
-- 
1.5.1.1

[U-Boot-Users] [PATCH] LOGO: Allow each board to define its own logo.

[Wolfgang Denk]

In message <20070527145833.GS21180@enneenne.com> you wrote:
> This allow developers to define per board logo file into boards' main
> configuration file (board/*/config.mk) as follow:

Sorry, but this is a misconception. The board/*/config.mk  is  NOT  a
configuration  file intended for such settings. The boards' main con-
figuration file is include/configs/<name>.h, and as far  as  possible
all configuration should be set there.

> 	# The logo bitmap
> 	LOGO_BMP = board/<name>/<logo>.bmp
> 
> Signed-off-by: Rodolfo Giometti <giometti@linux.it>
> ---
>  tools/Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index 6177f90..ad2824d 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -40,7 +40,7 @@ endif
>  LOGO_H	= $(OBJTREE)/include/bmp_logo.h
>  
>  ifeq ($(LOGO_BMP),)
> -LOGO_BMP= logos/denx.bmp
> +LOGO_BMP= tools/logos/denx.bmp
>  endif
>  
>  #-------------------------------------------------------------------------

Until here, I see no advantage by this patch. I  don't  think  adding
another level of subdirectoris is a win.

> @@ -203,8 +203,8 @@ $(obj)crc32.c:
>  		@rm -f $(obj)crc32.c
>  		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
>  
> -$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
> -		$(obj)./bmp_logo $(LOGO_BMP) >$@
> +$(LOGO_H):	$(obj)bmp_logo $(TOPDIR)/$(LOGO_BMP)
> +		$(obj)./bmp_logo $(TOPDIR)/$(LOGO_BMP) >$@

But this is a change to the worse. Before, I could define (for example
on the "make" command line:

	LOGO_BMP=/some/other/path/foo.bmp

which will now break as you unconditionally prefix this setting with
$(TOPDIR).



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
	-- Spock, "Journey to Babel", stardate 3842.4

[U-Boot-Users] [PATCH] LOGO: Allow each board to define its own logo.

[Rodolfo Giometti]

On Sun, May 27, 2007 at 10:58:25PM +0200, Wolfgang Denk wrote:
> In message <20070527145833.GS21180@enneenne.com> you wrote:
> > This allow developers to define per board logo file into boards' main
> > configuration file (board/*/config.mk) as follow:
> 
> Sorry, but this is a misconception. The board/*/config.mk  is  NOT  a
> configuration  file intended for such settings. The boards' main con-
> figuration file is include/configs/<name>.h, and as far  as  possible
> all configuration should be set there.

But doing like this how can I define the file to supply to the
logo_bmp utility? This settings is needed to get the file
"include/bmp_logo.h" which in turn is used for the compilation stage.

> >  ifeq ($(LOGO_BMP),)
> > -LOGO_BMP= logos/denx.bmp
> > +LOGO_BMP= tools/logos/denx.bmp
> >  endif
> >  
> >  #-------------------------------------------------------------------------
> 
> Until here, I see no advantage by this patch. I  don't  think  adding
> another level of subdirectoris is a win.

This is due the next change.

> > @@ -203,8 +203,8 @@ $(obj)crc32.c:
> >  		@rm -f $(obj)crc32.c
> >  		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
> >  
> > -$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
> > -		$(obj)./bmp_logo $(LOGO_BMP) >$@
> > +$(LOGO_H):	$(obj)bmp_logo $(TOPDIR)/$(LOGO_BMP)
> > +		$(obj)./bmp_logo $(TOPDIR)/$(LOGO_BMP) >$@
> 
> But this is a change to the worse. Before, I could define (for example
> on the "make" command line:
> 
> 	LOGO_BMP=/some/other/path/foo.bmp
> 
> which will now break as you unconditionally prefix this setting with
> $(TOPDIR).

I see...

I'm trying to find a good way to allow developers to define their own
logos since currently only denx.bmp is used in a not configurable way
(or at least I didn't find it).

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127