[U-Boot-Users] Bug in fat_register_device() ?

Wolfgang Denk
2007-06-04T19:17:20Z

Dear Heiko,

in message <1180970321.46642d51d24a1@webmail.mnet-online.de> you wrote:
>
> #if (CONFIG_COMMANDS & CFG_CMD_IDE) || (CONFIG_COMMANDS & CFG_CMD_SCSI) || \
> (CONFIG_COMMANDS & CFG_CMD_USB) || defined(CONFIG_SYSTEMACE)
> + {

Incorrect brace style.

> disk_partition_t info;
> if(!get_partition_info(dev_desc, part_no, &info)) {
> part_offset = info.start;
> cur_part = part_no;
> }
> else {

Ditto (not by you, but lease clean up anyway).

> }
> + }
> #else
> /* FIXME we need to determine the start block of the
--------^
> * partition where the DOS FS resides. This can be done
--------^
> @@ -109,7 +111,6 @@ fat_register_device(block_dev_desc_t *dev_desc, int part_no)
> part_offset=32;
--------^
> cur_part = 1;
--------^

Seems you should fix indentation in these lines, and everything
inbetween.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Es ist offensichtlich, dass das menschliche Gehirn wie ein Computer
funktioniert. Da es keine dummen Computer gibt, gibt es also auch
keine dummen Menschen. Nur ein paar Leute, die unter DOS laufen.
-- <unbekannt>