From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 5 Jun 2007 21:39:16 +0200 Subject: [U-Boot-Users] [PATCH] Added support for multiple serial for MPC8XX In-Reply-To: <20070605135307.5DD77353A97@atlas.denx.de> References: <20070605135307.5DD77353A97@atlas.denx.de> Message-ID: <200706052139.16320.sbabic@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 05 June 2007 15:53, Wolfgang Denk wrote: > Hi Stefano, > > in message <200706051447.35025.sbabic@denx.de> you wrote: > > > First, your SIgned-off-by: line is missing. Sorry, I will add it. > I really dislike this mess of #ifdef's I agree with you and I inserted this code against my will :) However, I didn't want to have two different coding styles with different meaning inside the same file. In fact, some lines later the whole mess of #ifdef was already inserted for the ppc4xx architecture using CONFIG_CONS_INDEX to switch among the interfaces. I didn't want to change this part because this would break all ppc4xx boards that are not part of the U-Boot tree. So I preferred to add a lot of #ifdef using the same CONFIG defines as in ppc4xx instead of creating a new one. However, you are right and if we add in future this feature for additional CPUs the code will become absolutely unreadable. I will resend the patch with the modifications for the mpc8xx, without touching ppc4xx part. This would not break any custom board. Regards, stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================