From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Added support for multiple serial for MPC8XX
Date: Wed, 6 Jun 2007 15:03:01 +0200 [thread overview]
Message-ID: <200706061503.02268.sbabic@denx.de> (raw)
In-Reply-To: <20070605234949.F2E1B353A05@atlas.denx.de>
On Wednesday 06 June 2007 01:49, Wolfgang Denk wrote:
> We should get rid of all this CONFIG_CONS_INDEX stuff.
>
CONFIG_CONS_INDEX has a useful meaning inside the NS16550 driver, so I do not
drop it. I removed only the mess inside common/serial.c in the same way as
you suggested for the mpc8xx.
> Please feel free to fix it for the existing 4xx boards as well. I'd
> really appreciate this, and I even volunteer to test it on a few of
> them.
If I am not wrong, only the mcc200 board for ppc4xx needs multiple serial
interfaces and uses the NS16550 driver, requiring some testing.
The PPC5200 based boards (the only other architecture using multiple serials)
do not use the NS16450 and they rely on the PSC driver, configured by the
CONFIG_UART1_CONSOLE (and I do not change this mechanism).
I have also noted that CONFIG_SERIAL_MULTI is always on for the mpc8xx (set
implicitely by include/common.h and not by the board config file), even if
there was no full support to have multiple serial interfaces.
I think this gave us the nice feature to have in a easy way one SMC and one
SCC and to switch between them (but not two SMCs or multiple SCCs), but
now with full support for multiple interfaces I think this behavior is wrong
and I removed it (it breaks all mpc8xx boards requiring to configure the
default console). Multiple interfaces must be enabled setting explicitely
CONFIG_SERIAL_MULTI in their config file. And at the moment, there is no
board where more that one CONFIG_8xx_CONS_XXX is set.
Regards,
stefano babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2007-06-06 13:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 12:47 [U-Boot-Users] [PATCH] Added support for multiple serial for MPC8XX Stefano Babic
2007-06-05 13:53 ` Wolfgang Denk
2007-06-05 19:39 ` Stefano Babic
2007-06-05 23:49 ` Wolfgang Denk
2007-06-06 5:08 ` Stefan Roese
2007-06-06 13:03 ` Stefano Babic [this message]
2007-06-06 13:13 ` Stefan Roese
2007-06-06 13:27 ` Stefano Babic
2007-06-06 13:55 ` Wolfgang Denk
2007-06-06 14:20 ` Stefano Babic
2007-06-06 21:35 ` [U-Boot-Users] [PATCH] Added support for multiple serial for MPC8XX (resubmit) Stefano Babic
2007-06-15 16:03 ` Detlev Zundel
2007-06-15 19:38 ` Wolfgang Grandegger
2007-06-17 13:31 ` Stefano Babic
2007-06-17 21:16 ` Wolfgang Denk
2007-06-18 5:18 ` Wolfgang Grandegger
2007-06-17 11:35 ` Stefano Babic
-- strict thread matches above, loose matches on Subject: below --
2007-06-05 13:56 [U-Boot-Users] [PATCH] Added support for multiple serial for MPC8XX Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706061503.02268.sbabic@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox