From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Timer IRQs appear broken on 8548/e500v2
Date: Wed, 6 Jun 2007 14:39:20 -0400 [thread overview]
Message-ID: <20070606183919.GA3490@windriver.com> (raw)
I'd built 1.2.0 for the MPC8548 CDS, and put that on an earlier board
which worked fine. Then I went to install it on a newer board (e500v2)
and the same image was giving me an illegal instruction fault. Once
I saw the latest git trees gave me the same error, I went back in time
and started poking around older versions and eventually tracked it down
to the timer IRQ support. Here is the patch I'm running now -- this
may not be the desired long term fix, but at least it will save people
the detective work part (which was kind of nasty, as the PHY code shows
up as the culprit, just out of coincidence...)
Thanks,
Paul.
---------
The interrupt support is broken on newer e500v2 boards. Trying to enable
it will result in an illegal instruction trap once the 1st TCR_PIE event
happens, which will roughly be around the PHY detection for the TSEC
(depending on your CPU speed). Since the interrupt generation is only
used for the periodic timer interrupts, which are in turn only used if you
are using the u-boot watchdog, a fix is to just disable it as per pre-1.1.4
u-boot versions.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
--- orig/u-boot-1.2.0/cpu/mpc85xx/interrupts.c 2007-01-06 18:13:11.000000000 -0500
+++ u-boot-1.2.0/cpu/mpc85xx/interrupts.c 2007-05-23 21:15:20.000000000 -0400
@@ -80,6 +80,7 @@
int interrupt_init (void)
{
+#ifdef CONFIG_MPC85xx_TIMER_IRQ
volatile immap_t *immr = (immap_t *)CFG_IMMR;
immr->im_pic.gcr = MPC85xx_PICGCR_RST;
@@ -89,6 +90,7 @@
mtspr(SPRN_TCR, TCR_PIE);
set_dec (decrementer_count);
set_msr (get_msr () | MSR_EE);
+#endif /* CONFIG_MPC85xx_TIMER_IRQ */
return (0);
}
reply other threads:[~2007-06-06 18:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070606183919.GA3490@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox