U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] IXP4xx Silicon version
Date: Thu, 7 Jun 2007 07:18:23 +0200	[thread overview]
Message-ID: <200706070718.23598.sr@denx.de> (raw)
In-Reply-To: <7EDC24AB1ED682439657D3B7790609D3982490@deepthought.Elpro.local>

Hi Jonathan,

On Thursday 07 June 2007, Jonathan Pratt wrote:
> I'm not sure if anyone else has found it to be a problem but some boards
> we recently had built have an IXP425 on them which reports a Product
> Revision value 0x2 (lowest four bits of CP15, reg 0).

Seems that Intel has released a new revision of the CPU.

> This is only a 
> problem because the file
>
> cpu/ixp/npe/npe.c
>
> uses this field in the npe_initialize function to decide how to
> determine how many ethernet ports there are. Unfortunately the case
> statement only accounts for revision values 0x0
> (IX_FEATURE_CTRL_SILICON_TYPE_A0) and 0x01
> (IX_FEATURE_CTRL_SILICON_TYPE_B0) so that the existing code doesn't
> think that these processors have any ethernet ports available. I found
> that by adding a 'default:' statement before line #639 remedied the
> problem. This file is part of u-boot, not the Intel npe library.

Would be interesting to know, what the differences of this new IXP425 revision 
are before "blindly" selecting default for Rev. A or Rev. B.

> Since it seems that someone is immanently about to release a patch on
> the npe stuff anyway, would it be too much trouble to add the 'default:'
> statement or otherwise handle this product revision?

Yes, "someone" is waiting for another revised patch. I could of course add 
this statement, but I can't test since I don't have IXP hardware right now. 
Did you test this change successfully on both ethernet ports?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2007-06-07  5:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.382022.1181166175.32383.u-boot-users@lists.sourceforge.net>
2007-06-06 22:38 ` [U-Boot-Users] IXP4xx Silicon version Jonathan Pratt
2007-06-07  5:18   ` Stefan Roese [this message]
2007-06-07  5:51     ` Jonathan Pratt
2007-06-07  7:43   ` Christian Hohnstaedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706070718.23598.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox