From: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] NAND patch update for KB9202B
Date: Sun, 10 Jun 2007 14:24:19 +0200 [thread overview]
Message-ID: <20070610122419.GG7048@traven> (raw)
In-Reply-To: <20070607230205.CECCC352681@atlas.denx.de>
hi wolfgang,
El Fri, Jun 08, 2007 at 01:02:05AM +0200 Wolfgang Denk ha dit:
> In message <20070607205405.GD7048@traven> you wrote:
> >
> > this is an update of the NAND support patch for the KB9202 board,
> > adapted to changes in the board specific Makefile
>
> Sorry, but I have to reject this patch. Please see
> http://www.denx.de/wiki/UBoot/Patches for help.
>
> * Signed-off-by: line is missing.
> * Patch is not inline, but compressed and thus unreadable
> * Patch contains coding style violations (C++ comments)
thanks for your comments, i'll take them into account in the future
this patch is void anyway, right after posting it i saw that christian
from kwikbyte just submitted a updated version of the patch i intended
to correct.
best regards
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
Usually when people are sad, they don't do anything. They just cry over
their condition. But when they get angry, they bring about a change
(Malcolm X)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
prev parent reply other threads:[~2007-06-10 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 20:54 [U-Boot-Users] NAND patch update for KB9202B Matthias Kaehlcke
2007-06-07 21:09 ` Matthias Kaehlcke
2007-06-07 23:02 ` Wolfgang Denk
2007-06-09 19:05 ` christian at kwikbyte.com
2007-06-09 23:11 ` Wolfgang Denk
2007-06-10 12:24 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070610122419.GG7048@traven \
--to=matthias.kaehlcke@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox