[U-Boot-Users] NAND patch update for KB9202B

[U-Boot-Users] NAND patch update for KB9202B

[Matthias Kaehlcke]

this is an update of the NAND support patch for the KB9202 board,
adapted to changes in the board specific Makefile

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

     La guerra es un acto abominable en el que se matan personas que no
      se conocen, dirigidas por personas que se conocen y no se matan
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nand.patch.gz
Type: application/octet-stream
Size: 3106 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070607/e14b972c/attachment.obj 

[U-Boot-Users] NAND patch update for KB9202B

[Matthias Kaehlcke]

El Thu, Jun 07, 2007 at 10:54:05PM +0200 Matthias Kaehlcke ha dit:

> this is an update of the NAND support patch for the KB9202 board,
> adapted to changes in the board specific Makefile

sorry, i hadn't seen the patch christian just submitted

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

    Tant qu'il y aura sur terre des hommes pour qui existe un concept
    d' 'honneur national', la menace d'une nouvelle guerre subsistera.
                              (B. Traven)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-

[U-Boot-Users] NAND patch update for KB9202B

[Wolfgang Denk]

In message <20070607205405.GD7048@traven> you wrote:
> 
> this is an update of the NAND support patch for the KB9202 board,
> adapted to changes in the board specific Makefile

Sorry, but I have to reject this patch. Please see
http://www.denx.de/wiki/UBoot/Patches for help.

* Signed-off-by: line is missing.
* Patch is not inline, but compressed and thus unreadable
* Patch contains coding style violations (C++ comments)

Also, why are you doing this:

+#ifndef        CONFIG_KB9202B_ATL
+/* 
+       AT91C_BASE_PIOC->PIO_SODR = AT91C_PIO_PC28;
+       AT91C_BASE_PIOC->PIO_ODR = AT91C_PIO_PC29;
+       AT91C_BASE_PIOC->PIO_PER = AT91C_PIO_PC28 | AT91C_PIO_PC29;
+       AT91C_BASE_PIOC->PIO_OER = AT91C_PIO_PC28;
+*/ 
+       AT91C_BASE_PIOC->PIO_SODR = ((unsigned)1<<28);
+       AT91C_BASE_PIOC->PIO_ODR = ((unsigned)1<<29);
+       AT91C_BASE_PIOC->PIO_PER = ((unsigned)1<<28) |
((unsigned)1<<29);
+       AT91C_BASE_PIOC->PIO_OER = ((unsigned)1<<28);
+#else
+/* 
+       AT91C_BASE_PIOB->PIO_SODR = AT91C_PIO_PB26;
+       AT91C_BASE_PIOB->PIO_ODR = AT91C_PIO_PB27;
+       AT91C_BASE_PIOB->PIO_PER = AT91C_PIO_PB26 | AT91C_PIO_PB27;
+       AT91C_BASE_PIOB->PIO_OER = AT91C_PIO_PB26;
+*/ 
+       AT91C_BASE_PIOB->PIO_SODR = ((unsigned)1<<26);
+       AT91C_BASE_PIOB->PIO_ODR = ((unsigned)1<<27);
+       AT91C_BASE_PIOB->PIO_PER = ((unsigned)1<<26) |
((unsigned)1<<27);
+       AT91C_BASE_PIOB->PIO_OER = ((unsigned)1<<26);
+#endif 

If the commented out code is wrong, then it should be removed. On the
other hand, it looks better to me  than  the  code  that  is  inplace
instead. Please clean up.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
panic: can't find /

[U-Boot-Users] NAND patch update for KB9202B

[christian at kwikbyte.com]

-----Original Message-----
From: u-boot-users-bounces@lists.sourceforge.net
[mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of
Wolfgang Denk
Sent: Thursday, June 07, 2007 4:02 PM
To: Matthias Kaehlcke
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: [U-Boot-Users] NAND patch update for KB9202B

In message <20070607205405.GD7048@traven> you wrote:
> 
> this is an update of the NAND support patch for the KB9202 board,
> adapted to changes in the board specific Makefile

Sorry, but I have to reject this patch. Please see
http://www.denx.de/wiki/UBoot/Patches for help.

* Signed-off-by: line is missing.
* Patch is not inline, but compressed and thus unreadable
* Patch contains coding style violations (C++ comments)

Also, why are you doing this:

+#ifndef        CONFIG_KB9202B_ATL
+/* 
+       AT91C_BASE_PIOC->PIO_SODR = AT91C_PIO_PC28;
+       AT91C_BASE_PIOC->PIO_ODR = AT91C_PIO_PC29;
+       AT91C_BASE_PIOC->PIO_PER = AT91C_PIO_PC28 | AT91C_PIO_PC29;
+       AT91C_BASE_PIOC->PIO_OER = AT91C_PIO_PC28;
+*/ 
+       AT91C_BASE_PIOC->PIO_SODR = ((unsigned)1<<28);
+       AT91C_BASE_PIOC->PIO_ODR = ((unsigned)1<<29);
+       AT91C_BASE_PIOC->PIO_PER = ((unsigned)1<<28) |
((unsigned)1<<29);
+       AT91C_BASE_PIOC->PIO_OER = ((unsigned)1<<28);
+#else
+/* 
+       AT91C_BASE_PIOB->PIO_SODR = AT91C_PIO_PB26;
+       AT91C_BASE_PIOB->PIO_ODR = AT91C_PIO_PB27;
+       AT91C_BASE_PIOB->PIO_PER = AT91C_PIO_PB26 | AT91C_PIO_PB27;
+       AT91C_BASE_PIOB->PIO_OER = AT91C_PIO_PB26;
+*/ 
+       AT91C_BASE_PIOB->PIO_SODR = ((unsigned)1<<26);
+       AT91C_BASE_PIOB->PIO_ODR = ((unsigned)1<<27);
+       AT91C_BASE_PIOB->PIO_PER = ((unsigned)1<<26) |
((unsigned)1<<27);
+       AT91C_BASE_PIOB->PIO_OER = ((unsigned)1<<26);
+#endif 

If the commented out code is wrong, then it should be removed. On the
other hand, it looks better to me  than  the  code  that  is  inplace
instead. Please clean up.

Best regards,

Wolfgang Denk


>>>>>>
The commented code was supposed to give a little more insight as to what
was going on in the absence of defined symbols, but really doesn't add
much - as you noticed.
I'm including a revised patch that removes the commented code you
pointed at.  No c++ comments, either.
The included patch is meant to replace the one I submitted 07JUN with
following body content:


Add NAND support on KB9202 boards.
Signed-off by: christian at kwikbyte.com


Thank you.
<<<<<<
 

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
panic: can't find /

------------------------------------------------------------------------
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kb9202_nand.patch
Type: application/octet-stream
Size: 8088 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070609/6f7c370d/attachment.obj 

[U-Boot-Users] NAND patch update for KB9202B

[Wolfgang Denk]

Dear Christian,

in message <000001c7aac9$37c38f60$b30196c0@jdesk0010> you wrote:
> 
> The included patch is meant to replace the one I submitted 07JUN with
> following body content:
> 
> 
> Add NAND support on KB9202 boards.
> Signed-off by: christian at kwikbyte.com

Sorry, but the Signed-off-by  line  requires  your  full  real  name.
Please  see  Documentation/SubmittingPatches in the Linux kernel tree
for details.

[Just resending the Signed-off-by  line  is sufficient. Thanks.]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An armed society is a polite society.

[U-Boot-Users] NAND patch update for KB9202B

[Matthias Kaehlcke]

hi wolfgang,

El Fri, Jun 08, 2007 at 01:02:05AM +0200 Wolfgang Denk ha dit:

> In message <20070607205405.GD7048@traven> you wrote:
> > 
> > this is an update of the NAND support patch for the KB9202 board,
> > adapted to changes in the board specific Makefile
> 
> Sorry, but I have to reject this patch. Please see
> http://www.denx.de/wiki/UBoot/Patches for help.
> 
> * Signed-off-by: line is missing.
> * Patch is not inline, but compressed and thus unreadable
> * Patch contains coding style violations (C++ comments)

thanks for your comments, i'll take them into account in the future

this patch is void anyway, right after posting it i saw that christian
from kwikbyte just submitted a updated version of the patch i intended
to correct.

best regards

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona


   Usually when people are sad, they don't do anything. They just cry over
     their condition. But when they get angry, they bring about a change
                              (Malcolm X)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-