public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Bug fix / safty measure for cfi_flash.c
Date: Thu, 21 Jun 2007 13:42:37 +0200	[thread overview]
Message-ID: <200706211342.37271.sr@denx.de> (raw)
In-Reply-To: <ffc2b1d40706202316r236943dlb1b766250f65786f@mail.gmail.com>

Hi Eran,

On Thursday 21 June 2007, eran liberty wrote:
> Without this additional check a flash that was defined in the config
> file with different size then the one reported by the flash chip
> itself. will cause array overrun and crash.
>
> the additional CONFIG_FORCE_FLASH_BANK_SIZE allows to set the size
> ignoring the chip actual size
>
> Signed-off-by: Eran Liberty
>
> diff -x .svn -Nuar
> u-boot.git-5ffa76a032279bc6d3230b703eda32d13305ba13/drivers/cfi_flash.c
> u-boot.exsw6000/drivers/cfi_flash.c
> --- u-boot.git-5ffa76a032279bc6d3230b703eda32d13305ba13/drivers/cfi_flash.c
> 2007-06-18 22:38:46.000000000 +0300
> +++ u-boot.exsw6000/drivers/cfi_flash.c 2007-06-20 19:05:01.000000000 +0300
> @@ -1281,7 +1281,7 @@
> erase_region_count = (tmp & 0xffff) + 1;

Again your patch seems to be not formatted correctly. Please use some decent 
parameter for patch creation via "diff" or use the git (or cogito) commands 
for patch creation (which is actually preferred).

I assume this will unfortunately be the case for all the patches you dent 
today. Please resubmit in a propper way.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2007-06-21 11:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-21  6:16 [U-Boot-Users] [PATCH] Bug fix / safty measure for cfi_flash.c eran liberty
2007-06-21 11:42 ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706211342.37271.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox