public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ppc4xx: Add pci_pre_init() for 405 boards
Date: Fri, 22 Jun 2007 08:04:53 +0200	[thread overview]
Message-ID: <200706220804.53277.sr@denx.de> (raw)
In-Reply-To: <20070621211450.21476352B87@atlas.denx.de>

On Thursday 21 June 2007, Wolfgang Denk wrote:
> > This patch adds support for calling a plattform dependant
> > pci_pre_init() function for 405 boards. This can be used to
> > move the current pci_405gp_fixup_irq() function into the
> > board code.
>
> I think we should  stop  using  this  method  to  provide  for  board
> specific code. Please use a weak function instead. See archive for
> earlier discussions of how to do that.

Yes, please.

Matthias just copied the already existing PPC440 example to the PPC405 code. 
But we should really stop extending the define mess right now. So Matthias, 
could you please implement this in the way Wolfgang descried? And if possible 
cleanup the 440 part too so that we can get rid of the CFG_PCI_PRE_INIT 
define completely?

Thanks.

Viele Gr??e,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2007-06-22  6:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-21 13:38 [U-Boot-Users] [PATCH] ppc4xx: Add pci_pre_init() for 405 boards Matthias Fuchs
2007-06-21 21:14 ` Wolfgang Denk
2007-06-22  6:04   ` Stefan Roese [this message]
2007-06-22 12:00     ` Matthias Fuchs
2007-06-22 12:11       ` Stefan Roese
2007-06-22 15:35         ` Matthias Fuchs
2007-06-22 15:44           ` Stefan Roese
2007-06-24 15:23             ` Matthias Fuchs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706220804.53277.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox