[U-Boot-Users] [PATCH 3/17] Minor code clean up.

[U-Boot-Users] [PATCH 3/17] Minor code clean up.

[Jerry Van Baren]

Declare the variable fdt properly as extern.
Call the "set_fn" function pointer the "short way" without the full
  dereferencing syntax.

Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>
---
 common/fdt_support.c |    5 +++++
 include/libfdt_env.h |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/common/fdt_support.c b/common/fdt_support.c
index bcdc415..15f133c 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -37,6 +37,11 @@
  */
 DECLARE_GLOBAL_DATA_PTR;
 
+/*
+ * fdt points to our working device tree.
+ */
+struct fdt_header *fdt;
+
 
 /********************************************************************/
 
diff --git a/include/libfdt_env.h b/include/libfdt_env.h
index e746314..78f7258 100644
--- a/include/libfdt_env.h
+++ b/include/libfdt_env.h
@@ -26,7 +26,7 @@
 #include <asm/byteorder.h>
 #include <linux/string.h>
 
-struct fdt_header *fdt;         /* Pointer to the working fdt */
+extern struct fdt_header *fdt;  /* Pointer to the working fdt */
 
 #define fdt32_to_cpu(x)		__be32_to_cpu(x)
 #define cpu_to_fdt32(x)		__cpu_to_be32(x)
-- 
1.4.4.4

[U-Boot-Users] [PATCH 3/17] Minor code clean up.

[Grant Likely]

On 7/4/07, Jerry Van Baren <gvb.uboot@gmail.com> wrote:
> Declare the variable fdt properly as extern.
> Call the "set_fn" function pointer the "short way" without the full
>   dereferencing syntax.
>
> Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>  common/fdt_support.c |    5 +++++
>  include/libfdt_env.h |    2 +-
>  2 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/common/fdt_support.c b/common/fdt_support.c
> index bcdc415..15f133c 100644
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c
> @@ -37,6 +37,11 @@
>   */
>  DECLARE_GLOBAL_DATA_PTR;
>
> +/*
> + * fdt points to our working device tree.
> + */
> +struct fdt_header *fdt;
> +
>
>  /********************************************************************/
>
> diff --git a/include/libfdt_env.h b/include/libfdt_env.h
> index e746314..78f7258 100644
> --- a/include/libfdt_env.h
> +++ b/include/libfdt_env.h
> @@ -26,7 +26,7 @@
>  #include <asm/byteorder.h>
>  #include <linux/string.h>
>
> -struct fdt_header *fdt;         /* Pointer to the working fdt */
> +extern struct fdt_header *fdt;  /* Pointer to the working fdt */
>
>  #define fdt32_to_cpu(x)                __be32_to_cpu(x)
>  #define cpu_to_fdt32(x)                __cpu_to_be32(x)
> --
> 1.4.4.4
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195