[U-Boot-Users] [PATCH 15/17] Create new fdt boardsetup command, fix bug parsing [] form of set values.

Jerry Van Baren
2007-07-05T10:36:52Z

Grant Likely wrote:
> On 7/4/07, Jerry Van Baren <gvb.uboot@gmail.com> wrote:
>> @@ -62,17 +58,6 @@ int fdt_chosen(void *fdt, ulong initrd_start, ulong
>> initrd_end, int force)
>> return err;
>> }
>>
>> -#ifdef CONFIG_OF_BOARD_SETUP
>> - /*
>> - * ft_board_setup() sets various board-specific properties to
>> - * the proper values.
>> - *
>> - * STRICTLY SPEAKING, this is out of place, but it isn't clear
>> - * where a better place would be.
>> - */
>> - ft_board_setup(fdt, bd);
>> -#endif
>> -
>
> Wasn't this code just added in an earlier patch in this series? :-)
>
> Cheers,
> g.

Yes, I took two steps - one to make it work and one to do it right and
didn't go back and consolidate the two in the patches. Patch 15/17 adds
the "fdt boardsetup" command which allowed me to remove this ugly.

Best regards,
gvb