From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 6 Jul 2007 15:52:33 +0200 Subject: [U-Boot-Users] Fix problem with get/setdcr commands introduced by cfg patches In-Reply-To: References: <200707060945.47900.sr@denx.de> Message-ID: <200707061552.33717.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 06 July 2007, Jon Loeliger wrote: > > -#if defined(CONFIG_4xx) && defined(CFG_CMD_SETGETDCR) > > +#if defined(CONFIG_4xx) && ((CONFIG_COMMANDS & CFG_CMD_SETGETDCR) || > > defined(CONFIG_CMD_SETGETD CR)) > > > > #include > > Sorry about that. No problem. > Hmmm... Something is fishy here if this is a problem... > > While the above is a valid (temporary) "fix", > I think rather than re-introducing this clause: > > (CONFIG_COMMANDS & CFG_CMD_SETGETDCR) > > a better (long term) solution is to try and figure out > why CONFIG_CMD_SETGETDCR isn't available. The goal is > to eliminate the CONFIG_COMMAND symbol, so we should > be able to compile this file without it. I have no problems with just using: #if defined(CONFIG_4xx) && defined(CONFIG_CMD_SETGETDCR) here. But we had: #if defined(CONFIG_4xx) && defined(CFG_CMD_SETGETDCR) So this couldn't work. > My guesses off the top of my head: > > 1) I blitzed CONFIG_CMD_SETGETDCR in the 4xx.h config file > 2) The 4xx board config file isn't being included here > 3) Interaction with a .S file > 4) Some secondary #include effect making config_cmd_default.h > be not included > > Please let me know if I can further here. Feel free to clean this up with your next patchset. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================