From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 27 Jul 2007 06:51:07 +0200
Subject: [U-Boot-Users] U-boot ColdFire development
In-Reply-To: <4791E710007FEB4BBF83775D787F462F048C7FFD@az33exm22.fsl.freescale.net>
References: <4791E710007FEB4BBF83775D787F462F04749339@az33exm22.fsl.freescale.net>
	<46A78E53.28004.1ACA825@w.wegner.astro-kom.de>
	<4791E710007FEB4BBF83775D787F462F048C7FFD@az33exm22.fsl.freescale.net>
Message-ID: <200707270651.07904.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

TsiChung,

On Friday 27 July 2007, Liew Tsi Chung-r5aahp wrote:
> > For the sync() function (needed for CFI):
> > is it useful to have it for each board, or shouldn?t this be
> > handled somewhere in lib_m68k?
>
> Have not looked deep into the CFI driver code to see there is a need for
> it. If there is no need for it, it will be removed.

The sync() in the CFI driver *is* needed. At least on some architectures. 
Please move the definition of sync() from the board specific file to the 
common header include/asm-m68k/io.h to something like this:

static inline void sync(void)
{
	/*
	 * Not needed on ColdFire architecture
	 * Added for compatibility reasons (CFI driver...)
	 */
}

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================