From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Update for 5329
Date: Thu, 2 Aug 2007 07:23:21 +0200 [thread overview]
Message-ID: <200708020723.21431.sr@denx.de> (raw)
In-Reply-To: <02fb01c7d461$677fbf50$1a0510ac@CRAIG>
Hi Craig,
On Wednesday 01 August 2007, Craig Day wrote:
> I've ported u-boot 1.1.6 over to the LPC3180 (arm926ejs core) and have
> included NAND support. The nand_write_ecc function in
> drivers/nand/nand_base.c appears to be writing pages correctly, but the
> pointer to the source data in memory for nand_verify_pages does not seem to
> be updated correctly. Specifically, line 1707 in nand_base.c contains:
> this->data_poi = bufstart; However, the problem is that bufstart is never
> updated, and always points to the beginning of the data source, causing all
> nand_page_verify calls to compare the newest written pages in NAND flash to
> the beginning of the data source. After the first block NAND writing fails
> due to nand_verify_pages failing. To fix this I added in:
> bufstart += (1 << this->phys_erase_shift);
Thanks for the detailed explanation. But even better would be to send a patch
(best with a signed-off line etc.). A patch sometimes explains a problem
betten than such an explanation. And if you are correct and it fixes a real
problem, the patch could be applied directly.
> Have you seen this problem? Or has anyone else run into this problem? Or is
> there something I'm missing?
We are using the current NAND driver successfully on multiple boards.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2007-08-02 5:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 16:13 [U-Boot-Users] Update for 5329 Liew Tsi Chung-r5aahp
2007-08-01 17:28 ` Craig Day
2007-08-02 5:23 ` Stefan Roese [this message]
2007-08-02 15:14 ` Craig Day
2007-08-02 15:22 ` Stefan Roese
2007-08-02 5:56 ` Stefan Roese
2007-08-06 20:52 ` [U-Boot-Users] Update for 5329 - part I Liew Tsi Chung-r5aahp
2007-08-08 8:02 ` Stefan Roese
2007-08-06 20:53 ` [U-Boot-Users] Update for 5329 - part II Liew Tsi Chung-r5aahp
2007-08-08 8:03 ` Stefan Roese
2007-08-08 8:08 ` Liew Tsi Chung-r5aahp
2007-08-14 17:27 ` [U-Boot-Users] ColdFire: Timer and MCF52x2 update Liew Tsi Chung-r5aahp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708020723.21431.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox