[U-Boot-Users] interrupts in general / Fix for mcf5329evb - spurious interrupts on Linux/uClinux kernel boot

Bob Grimes
2007-08-10T12:17:41Z

Here I was, preparing the patch in the correct format, and I decided
to check my inbox!

On 8/10/07, w.wegner at astro-kom.de <w.wegner@astro-kom.de> wrote:
> > > Attached is a very small patch that implements the fix - when
> > > CONFIG_MCF532x is defined, the timer interrupt is masked immediately
> > > prior to calling into the kernel. I don't know if this is the right way
> is this considered the correct solution?

I don't know! :)

>
> Please correct me if I am wrong, but should not interrupts be completely
> disabled before transferring control to the linux kernel to avoid any confusion?
>
> In this case, I think we should have a function doing this in cpu/.../interrupts.c
> and call this function always befor control is transferred to the linux kernel.
> Additionally, this would prevent additional #ifdefs, because the cpu specific
> things would be handled in cpu/.../interrupts.c.
>
> For mcf532x, interrupt_init() does exactly this, but this seems not the case
> for mcf52x2, at least not for all the processors handled there.
>

I don't know the "big picture" for Das U-Boot, so I can't really
comment here, other than to note that fewer #ifdefs is good!

I can send my patch in at any time, but until this is resolved, I'm
going to hold off...

-Bob