From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 10 Aug 2007 15:15:00 +0200 Subject: [U-Boot-Users] interrupts in general / Fix for mcf5329evb - spurious interrupts on Linux/uClinux kernel boot In-Reply-To: <20070810125612.7FE6D353428@atlas.denx.de> References: <20070810125612.7FE6D353428@atlas.denx.de> Message-ID: <200708101515.00624.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 10 August 2007, Wolfgang Denk wrote: > > Please correct me if I am wrong, but should not interrupts be completely > > disabled before transferring control to the linux kernel to avoid any > > confusion? > > Right. IIRC the function we are talking about here is do_bootm_linux() (m68k version) which is called from the common do_bootm() function. Before calling do_bootm_linux() the follwing code is called: /* * We have reached the point of no return: we are going to * overwrite all exception vector code, so we cannot easily * recover from any failures any more... */ iflag = disable_interrupts(); So at the point of do_bootm_linux() the interrupts should already be off. If this is not the case, then it is probably better to fix this in the disable_interrupts implementation of the ColdFire. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================