public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] ColdFire: MCF52x2 update
@ 2007-08-14 17:54 Liew Tsi Chung-r5aahp
  2007-08-14 19:05 ` Wolfgang Denk
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Liew Tsi Chung-r5aahp @ 2007-08-14 17:54 UTC (permalink / raw)
  To: u-boot

Stefan,

	There are 17 patches and over 234KB. I kept sending over 40KB
limit. Can you pull from our git at http://opensource.freescale.com/git
? The branch will name as mcf52x2.

	Sorry for the trouble. Thanks!

Regards,
TsiChung

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire: MCF52x2 update
  2007-08-14 17:54 [U-Boot-Users] ColdFire: MCF52x2 update Liew Tsi Chung-r5aahp
@ 2007-08-14 19:05 ` Wolfgang Denk
  2007-08-15 12:44 ` Stefan Roese
  2007-08-20 13:06 ` [U-Boot-Users] ColdFire custodian change? Stefan Roese
  2 siblings, 0 replies; 12+ messages in thread
From: Wolfgang Denk @ 2007-08-14 19:05 UTC (permalink / raw)
  To: u-boot

In message <4791E710007FEB4BBF83775D787F462F049A3673@az33exm22.fsl.freescale.net> you wrote:
> 
> 	There are 17 patches and over 234KB. I kept sending over 40KB
> limit. Can you pull from our git at http://opensource.freescale.com/git
> ? The branch will name as mcf52x2.

Sorry, patches have to be submitted over the mailing list for review.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a very small mind and must live with it.    -- Edsger Dijkstra

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire: MCF52x2 update
  2007-08-14 17:54 [U-Boot-Users] ColdFire: MCF52x2 update Liew Tsi Chung-r5aahp
  2007-08-14 19:05 ` Wolfgang Denk
@ 2007-08-15 12:44 ` Stefan Roese
  2007-08-15 12:58   ` [U-Boot-Users] ColdFire merge? (was: MCF52x2 update) w.wegner at astro-kom.de
  2007-08-16  1:58   ` [U-Boot-Users] ColdFire: MCF52x2 update Liew Tsi Chung-r5aahp
  2007-08-20 13:06 ` [U-Boot-Users] ColdFire custodian change? Stefan Roese
  2 siblings, 2 replies; 12+ messages in thread
From: Stefan Roese @ 2007-08-15 12:44 UTC (permalink / raw)
  To: u-boot

TsiChung,

On Tuesday 14 August 2007, Liew Tsi Chung-r5aahp wrote:
> 	There are 17 patches and over 234KB. I kept sending over 40KB
> limit. Can you pull from our git at http://opensource.freescale.com/git
> ? The branch will name as mcf52x2.

Hmmm. I'm having trouble locating your branch "mcf52x2". In the 
u-boot-coldfire repository at the Freescale page I can only see:

13 days ago	u-boot-5329-early
5 weeks ago	master

What am I missing? I would really like to pull from your git repo instead of 
applying all the patches from the mails.

A few notes right now:

o Please make sure not to indent with spaces like in the patch 0001-xxx:

+#if defined(CONFIG_M5249) || defined(CONFIG_M5253)
+        u16 tmr;                /* 0x00 Mode register */
+        u16 res1;               /* 0x02 */

o Please don't use too long lines in your commit messages

o I merged the u-boot-coldfire custodian repository today with
  Wolfgangs master repository. So now the new CONFIG_CMD_
  structure is in place. All CFG_CMD_xxx are not available
  anymore!
  -> Please update your new board config files accordingly
     (M5329EVB and new ones)
  -> Please update driver (board/freescale/m5329evb/mii.c,
     board/freescale/m5329evb/nand.c, common/cmd_bdinfo.c,
     drivers/net/mcffec.c, rtc/mcfrtc.c
  Please grep through your repo and replace all CFG_CMD_xxx
  instances with the correct CONFIG_CMD_xxx alternatives.

Please rebase your repository against the new updated u-boot-coldfire 
repository and make the CFG_CMD_xxx changes I mentioned above. Hopefully we 
can still get this done in this merge window.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire merge? (was: MCF52x2 update)
  2007-08-15 12:44 ` Stefan Roese
@ 2007-08-15 12:58   ` w.wegner at astro-kom.de
  2007-08-15 14:35     ` Stefan Roese
  2007-08-15 17:58     ` Liew Tsi Chung-r5aahp
  2007-08-16  1:58   ` [U-Boot-Users] ColdFire: MCF52x2 update Liew Tsi Chung-r5aahp
  1 sibling, 2 replies; 12+ messages in thread
From: w.wegner at astro-kom.de @ 2007-08-15 12:58 UTC (permalink / raw)
  To: u-boot

Hi Coldfire experts,

just a question:

how about my cache patch for SDRAM size other than 16MB on MCF532x?

I did not hear anything about it, not even a "go away, your patch format is wrong!". ;-)

In case the MCF532x stuff is merged into mainline now, I think this really should
go in or at least be commented on.

Personally I would also like to have support for CFG_MONITOR_IS_IN_RAM,
but if this is not wanted anyways, I do not have to take the time to prepare a patch...

Thank you and best regards,
Wolfgang

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire merge? (was: MCF52x2 update)
  2007-08-15 12:58   ` [U-Boot-Users] ColdFire merge? (was: MCF52x2 update) w.wegner at astro-kom.de
@ 2007-08-15 14:35     ` Stefan Roese
  2007-08-15 17:58     ` Liew Tsi Chung-r5aahp
  1 sibling, 0 replies; 12+ messages in thread
From: Stefan Roese @ 2007-08-15 14:35 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

On Wednesday 15 August 2007, w.wegner at astro-kom.de wrote:
> just a question:
>
> how about my cache patch for SDRAM size other than 16MB on MCF532x?
>
> I did not hear anything about it, not even a "go away, your patch format is
> wrong!". ;-)

We'll include it. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire merge? (was: MCF52x2 update)
  2007-08-15 12:58   ` [U-Boot-Users] ColdFire merge? (was: MCF52x2 update) w.wegner at astro-kom.de
  2007-08-15 14:35     ` Stefan Roese
@ 2007-08-15 17:58     ` Liew Tsi Chung-r5aahp
  1 sibling, 0 replies; 12+ messages in thread
From: Liew Tsi Chung-r5aahp @ 2007-08-15 17:58 UTC (permalink / raw)
  To: u-boot

Wolfgang,

	The patch for sdram size will be included.

	As for the CFG_MONITOR_IS_IN_RAM will not be included this time.

Regards,
TsiChung 

-----Original Message-----
From: w.wegner@astro-kom.de [mailto:w.wegner at astro-kom.de] 
Sent: Wednesday, August 15, 2007 7:59 AM
To: Stefan Roese; u-boot-users at lists.sourceforge.net; Liew Tsi
Chung-r5aahp
Subject: Re: [U-Boot-Users] ColdFire merge? (was: MCF52x2 update)

Hi Coldfire experts,

just a question:

how about my cache patch for SDRAM size other than 16MB on MCF532x?

I did not hear anything about it, not even a "go away, your patch format
is wrong!". ;-)

In case the MCF532x stuff is merged into mainline now, I think this
really should go in or at least be commented on.

Personally I would also like to have support for CFG_MONITOR_IS_IN_RAM,
but if this is not wanted anyways, I do not have to take the time to
prepare a patch...

Thank you and best regards,
Wolfgang

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire: MCF52x2 update
  2007-08-15 12:44 ` Stefan Roese
  2007-08-15 12:58   ` [U-Boot-Users] ColdFire merge? (was: MCF52x2 update) w.wegner at astro-kom.de
@ 2007-08-16  1:58   ` Liew Tsi Chung-r5aahp
  1 sibling, 0 replies; 12+ messages in thread
From: Liew Tsi Chung-r5aahp @ 2007-08-16  1:58 UTC (permalink / raw)
  To: u-boot

Stefan,

	I am updating all the changes. Will let you know when it is ready. Thanks!

Regards,
TsiChung 

-----Original Message-----
From: Stefan Roese [mailto:sr at denx.de] 
Sent: Wednesday, August 15, 2007 7:45 AM
To: Liew Tsi Chung-r5aahp
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: ColdFire: MCF52x2 update

TsiChung,

On Tuesday 14 August 2007, Liew Tsi Chung-r5aahp wrote:
> 	There are 17 patches and over 234KB. I kept sending over 40KB limit. 
> Can you pull from our git at http://opensource.freescale.com/git
> ? The branch will name as mcf52x2.

Hmmm. I'm having trouble locating your branch "mcf52x2". In the u-boot-coldfire repository at the Freescale page I can only see:

13 days ago	u-boot-5329-early
5 weeks ago	master

What am I missing? I would really like to pull from your git repo instead of applying all the patches from the mails.

A few notes right now:

o Please make sure not to indent with spaces like in the patch 0001-xxx:

+#if defined(CONFIG_M5249) || defined(CONFIG_M5253)
+        u16 tmr;                /* 0x00 Mode register */
+        u16 res1;               /* 0x02 */

o Please don't use too long lines in your commit messages

o I merged the u-boot-coldfire custodian repository today with
  Wolfgangs master repository. So now the new CONFIG_CMD_
  structure is in place. All CFG_CMD_xxx are not available
  anymore!
  -> Please update your new board config files accordingly
     (M5329EVB and new ones)
  -> Please update driver (board/freescale/m5329evb/mii.c,
     board/freescale/m5329evb/nand.c, common/cmd_bdinfo.c,
     drivers/net/mcffec.c, rtc/mcfrtc.c
  Please grep through your repo and replace all CFG_CMD_xxx
  instances with the correct CONFIG_CMD_xxx alternatives.

Please rebase your repository against the new updated u-boot-coldfire repository and make the CFG_CMD_xxx changes I mentioned above. Hopefully we can still get this done in this merge window.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de =====================================================================

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire custodian change?
  2007-08-14 17:54 [U-Boot-Users] ColdFire: MCF52x2 update Liew Tsi Chung-r5aahp
  2007-08-14 19:05 ` Wolfgang Denk
  2007-08-15 12:44 ` Stefan Roese
@ 2007-08-20 13:06 ` Stefan Roese
  2007-08-20 23:45   ` Liew Tsi Chung-r5aahp
  2 siblings, 1 reply; 12+ messages in thread
From: Stefan Roese @ 2007-08-20 13:06 UTC (permalink / raw)
  To: u-boot

Hi TsiChung,

we already talked about it in private mail, but I would like to switch this to 
the list, so that the community can follow (and comment) this thread. You are 
very active in ColdFire U-Boot development and seem to be much better suited 
to do this custodian job for this platform than I am right now.

So again my question to you: Are you willing to become the new ColdFire U-Boot 
custodian? Please let me know if you have any questions about this. I would 
welcome a "yes" very much. ;)

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire custodian change?
  2007-08-20 13:06 ` [U-Boot-Users] ColdFire custodian change? Stefan Roese
@ 2007-08-20 23:45   ` Liew Tsi Chung-r5aahp
  2007-08-21  5:30     ` Stefan Roese
  0 siblings, 1 reply; 12+ messages in thread
From: Liew Tsi Chung-r5aahp @ 2007-08-20 23:45 UTC (permalink / raw)
  To: u-boot

Stefan,

	Before answering your question, I would like to know more about becoming a ColdFire U-boot custodian. What are the job duties as a U-boot custodian other than maintaining, updating and merging the u-boot source from/to main branch? Do I need a user account at Denx?

	Thanks!

Regards,
TsiChung

-----Original Message-----
From: Stefan Roese [mailto:sr at denx.de] 
Sent: Monday, August 20, 2007 8:07 AM
To: Liew Tsi Chung-r5aahp
Cc: u-boot-users at lists.sourceforge.net; Wolfgang Denk
Subject: ColdFire custodian change?

Hi TsiChung,

we already talked about it in private mail, but I would like to switch this to the list, so that the community can follow (and comment) this thread. You are very active in ColdFire U-Boot development and seem to be much better suited to do this custodian job for this platform than I am right now.

So again my question to you: Are you willing to become the new ColdFire U-Boot custodian? Please let me know if you have any questions about this. I would welcome a "yes" very much. ;)

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de =====================================================================

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire custodian change?
  2007-08-20 23:45   ` Liew Tsi Chung-r5aahp
@ 2007-08-21  5:30     ` Stefan Roese
  2007-08-22 23:02       ` Liew Tsi Chung-r5aahp
  0 siblings, 1 reply; 12+ messages in thread
From: Stefan Roese @ 2007-08-21  5:30 UTC (permalink / raw)
  To: u-boot

TsiChung,

On Tuesday 21 August 2007, Liew Tsi Chung-r5aahp wrote:
> 	Before answering your question, I would like to know more about becoming a
> ColdFire U-boot custodian. What are the job duties as a U-boot custodian
> other than maintaining, updating and merging the u-boot source from/to main
> branch?

That's it. This includes reviewing ColdFire related patches of course. And 
making sure that everything in your custodian repository is according to the 
U-Boot standards (coding style etc.). You can of course always ask, if you 
are unsure or have any questions. Please take a loot at this page too:

http://www.denx.de/wiki/UBoot/CustodianGitTrees

> Do I need a user account at Denx? 

You just need to send us your ssh public key, so that we can give you write 
access to the ColdFire custodian repository.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire custodian change?
  2007-08-21  5:30     ` Stefan Roese
@ 2007-08-22 23:02       ` Liew Tsi Chung-r5aahp
  2007-08-23  5:42         ` Stefan Roese
  0 siblings, 1 reply; 12+ messages in thread
From: Liew Tsi Chung-r5aahp @ 2007-08-22 23:02 UTC (permalink / raw)
  To: u-boot

Stefan,

	We have one candidate is better suit for ColdFire custodian, and his name is John Rigby. He will be transition to take the ColdFire custodian responsibilites in this coming early October. For now, I can temporary take the responsibilites until then. Is this proposal okay with you and Wolfgang?

Regards,
TsiChung
	 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [U-Boot-Users] ColdFire custodian change?
  2007-08-22 23:02       ` Liew Tsi Chung-r5aahp
@ 2007-08-23  5:42         ` Stefan Roese
  0 siblings, 0 replies; 12+ messages in thread
From: Stefan Roese @ 2007-08-23  5:42 UTC (permalink / raw)
  To: u-boot

Hi TsiChung,

On Thursday 23 August 2007, Liew Tsi Chung-r5aahp wrote:
> 	We have one candidate is better suit for ColdFire custodian, and his name
> is John Rigby.

May I ask why this is the case? I have a few mails from John, but most of the 
CodFire stuff sent to the list was done by yourself.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2007-08-23  5:42 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-14 17:54 [U-Boot-Users] ColdFire: MCF52x2 update Liew Tsi Chung-r5aahp
2007-08-14 19:05 ` Wolfgang Denk
2007-08-15 12:44 ` Stefan Roese
2007-08-15 12:58   ` [U-Boot-Users] ColdFire merge? (was: MCF52x2 update) w.wegner at astro-kom.de
2007-08-15 14:35     ` Stefan Roese
2007-08-15 17:58     ` Liew Tsi Chung-r5aahp
2007-08-16  1:58   ` [U-Boot-Users] ColdFire: MCF52x2 update Liew Tsi Chung-r5aahp
2007-08-20 13:06 ` [U-Boot-Users] ColdFire custodian change? Stefan Roese
2007-08-20 23:45   ` Liew Tsi Chung-r5aahp
2007-08-21  5:30     ` Stefan Roese
2007-08-22 23:02       ` Liew Tsi Chung-r5aahp
2007-08-23  5:42         ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox