From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mpc83xx: Split PIB init code from pci.c and add Qoc3 ATM card support
Date: Thu, 16 Aug 2007 19:21:49 -0500 [thread overview]
Message-ID: <20070816192149.2c4b79f7.kim.phillips@freescale.com> (raw)
In-Reply-To: <1187242491.31097.19.camel@localhost.localdomain>
On 16 Aug 2007 13:34:51 +0800
Tony Li <tony.li@freescale.com> wrote:
> The patch splits the PIB init code from pci.c to a single file board/freescale/common/pq-mds-pib.c
> And add Qoc3 ATM card support for MPC8360EMDS and MPC832XEMDS board.
>
> Signed-off-by: Tony Li <tony.li@freescale.com>
>
it appears this patch is corrupt:
---
$ ../linux-2.6/scripts/checkpatch.pl --no-tree 53
ERROR: patch seems to be corrupt (line wrapped?)
#109: FILE: board/freescale/common/pq-mds-pib.c:6:
it
ERROR: patch seems to be corrupt (line wrapped?)
#216: FILE: board/freescale/common/pq-mds-pib.h:4:
it
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
---
please resend after turning off line wrapping in your mailer.
> +++ b/include/configs/MPC832XEMDS.h
> @@ -30,6 +30,9 @@
> #define CONFIG_MPC83XX 1 /* MPC83xx family */
> #define CONFIG_MPC832X 1 /* MPC832x CPU specific */
> #define CONFIG_MPC832XEMDS 1 /* MPC832XEMDS board specific */
> +#undef CONFIG_PQ_MDS_PIB /* POWERQUICC MDS Platform IO Board */
> +
> +#undef CONFIG_PQ_MDS_PIB_ATM /* QOC3 ATM card */
whilst you're at it, please move the blank line above the undef PIB line, to
indicate the h/w relationship.
Thanks,
Kim
next prev parent reply other threads:[~2007-08-17 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 5:34 [U-Boot-Users] [PATCH] mpc83xx: Split PIB init code from pci.c and add Qoc3 ATM card support Tony Li
2007-08-17 0:21 ` Kim Phillips [this message]
2007-08-17 2:26 ` Li Tony-r64360
-- strict thread matches above, loose matches on Subject: below --
2007-08-17 2:35 Tony Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070816192149.2c4b79f7.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox