From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] PCI_READ_VIA_DWORD_OP: Fix *val uninitialized bug
Date: Sat, 18 Aug 2007 21:39:09 +0200 [thread overview]
Message-ID: <20070818193909.EA8DA2410C@gemini.denx.de> (raw)
In-Reply-To: Your message of "Fri, 17 Aug 2007 12:43:44 +0900." <46C51970.6000207@necel.com>
In message <46C51970.6000207@necel.com> you wrote:
> From: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
>
> This patch has been sent on:
> - 6 Jun 2007
>
> Many users of PCI config read routines tend to ignore the function
> ret value, and are only concerned about the contents of *val. Based
> on this, pci_hose_read_config_{byte,word}_via_dword should initialize
> the *val on dword read error.
>
> Without this fix, for example, we'll go on scanning bus with vendor or
> header_type uninitialized. This brings many unnecessary config trials.
>
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Unix is simple, but it takes a genius to understand the simplicity."
- Dennis Ritchie
prev parent reply other threads:[~2007-08-18 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 3:43 [U-Boot-Users] [PATCH] PCI_READ_VIA_DWORD_OP: Fix *val uninitialized bug Shinya Kuribayashi
2007-08-18 19:39 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070818193909.EA8DA2410C@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox