From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Some RFCs about U-Boot's the generic FPGA support
Date: Tue, 21 Aug 2007 14:53:28 +0200 [thread overview]
Message-ID: <200708211453.28731.matthias.fuchs@esd-electronics.com> (raw)
In-Reply-To: <200708211333.02003.laurentp@cse-semaphore.com>
Laurent,
On Tuesday 21 August 2007 13:33, Laurent Pinchart wrote:
> On Tuesday 21 August 2007 12:46, Matthias Fuchs wrote:
> > Laurent,
> >
> > now things are getting clearer.
> > All this sounds to me that the shift direction in
> > slave serial mode is not compatible to the parallel download
> > code. When we say that fpga_load (and the fpga load command) should only
> > work for promgen files with mirrored bits and fpga_loadbitstream()
> > (and the fpga loadb command) should be used for .bit files, I
> > would like to get rid of the mirroring at least for slave serial mode
> > because changing the shift order is much more efficient.
>
> If I understand things well, you would like to get rid of the bit mirroring
> code to optimize slave serial loading (where changing the shift direction has
> no performance impact).
yes.
>
> > Bruce suggested a CONFIG option to turn on/off mirroring. This is
> > not the right way. It should be handled by the FPGA subsystem.
>
> Agreed.
>
> > What about passing a bitorder flag down to the load functions?
> > So we get rid of the huge malloc in loadbitstream and we can
> > just swap bits in parallel mode just before writing it to the
> > FPGA port.
>
> Would it have an impact on slave parallel performances ? Mirroring each byte
> separately in the slave parallel code might slow things down. I personally
> don't use the bitstream mirroring code (I use PROM files, so the bitstream is
> mirrored on the host before loading it to the target flash memory), but it
> might affect other users.
Well, there is only one public board that uses the FPGA code.
>
> > For Slave serial mode the _load funtion can use
> > the correct shift direction and so swapping is needed.
>
> I suppose you mean "swapping is not needed", as the load function would choose
> the shift direction depending on the bitorder flag.
yes, of course.
>
> it seemed cleaner to me to handler mirroring at the high level, so lower-level
> layers wouldn't have to care about it. If you want to optimize performances,
> why don't you use a PROM file instead of a .bit file ?
We never used prom files before:-) And as you have noticed I was not aware of this
mirroring issues before. I also do not want to miss the informational header of the
.bit files.
In the end I will starting fixing the current implementation keeping the swapping
in 'loadb' but this means that the shift direction of the serial slave functions
must be changed.
Matthias
next prev parent reply other threads:[~2007-08-21 12:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 13:13 [U-Boot-Users] Some RFCs about U-Boot's the generic FPGA support Matthias Fuchs
2007-08-20 13:47 ` Laurent Pinchart
2007-08-20 15:46 ` Matthias Fuchs
2007-08-21 8:59 ` Laurent Pinchart
2007-08-21 10:46 ` Matthias Fuchs
2007-08-21 11:33 ` Laurent Pinchart
2007-08-21 12:53 ` Matthias Fuchs [this message]
2007-08-21 20:09 ` Bruce_Leonard at selinc.com
2007-08-22 7:28 ` Laurent Pinchart
2007-08-22 7:59 ` Matthias Fuchs
2007-08-22 8:23 ` Laurent Pinchart
2007-08-22 17:12 ` Bruce_Leonard at selinc.com
2007-08-22 17:09 ` Bruce_Leonard at selinc.com
2007-08-22 17:33 ` Jerry Van Baren
2007-08-22 18:03 ` [U-Boot-Users] Loading vxWorks by u-boot Leonid
2007-08-22 19:40 ` Chris Fester
2007-08-22 20:12 ` Leonid
2007-08-22 20:42 ` Chris Fester
2007-08-22 21:18 ` Leonid
2007-08-22 20:12 ` Frank
2007-08-23 6:27 ` [U-Boot-Users] Antw: " Niklaus Giger
2007-10-09 20:04 ` [U-Boot-Users] Some RFCs about U-Boot's the generic FPGA support Bruce_Leonard at selinc.com
2007-08-23 7:41 ` Matthias Fuchs
2007-08-23 18:59 ` Bruce_Leonard at selinc.com
2007-08-20 13:52 ` Wolfgang Denk
2007-08-20 18:46 ` Bruce_Leonard at selinc.com
2007-08-21 8:30 ` Matthias Fuchs
2007-08-21 19:37 ` Bruce_Leonard at selinc.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708211453.28731.matthias.fuchs@esd-electronics.com \
--to=matthias.fuchs@esd-electronics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox