From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 29 Aug 2007 02:00:00 +0200 Subject: [U-Boot-Users] FIX: dataflash.c In-Reply-To: Your message of "Mon, 20 Aug 2007 07:26:14 +0200." <1187587574.31921.58.camel@elrond.sweden.atmel.com> Message-ID: <20070829000000.3AACF24744@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ulf, in message <1187587574.31921.58.camel@elrond.sweden.atmel.com> you wrote: > > > > Why not call it dataflash_cs[] and move it into the board code? It > > > already pollutes the namespace, is already board-dependent (hence the > > > #ifdefs) and is apparently buggy? > > > > Excellent idea. > > > > > Then the board code is responsible for defining a > > > CFG_MAX_DATAFLASH_BANKS symbol which corresponds with the actual > > > number of entries in the array. Of course, it can still be buggy, but > > > at least it's contained within the board code. > > > > I agree completely. > > > > > > Who will provide such a patch? > > I can do it, in a week or two. Just to make sure I understand correctly: are you working on this? Any estimates when it might be ready? Thanks in advance. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Probably the best operating system in the world is the [operating system] made for the PDP-11 by Bell Laboratories." - Ted Nelson, October 1977