[U-Boot-Users] [PATCH 1/5] OneNAND support

[Wolfgang Denk <wd@denx.de>]

Hello,

in message <002201c7f344$539d6c60$e1ac580a@swcenter.sec.samsung.co.kr> you wrote:
>
> P.S. Now I just send the modified parts, after full comments, I will send it at once.

OK - thanks!

> +U_BOOT_CMD(
> +	onenand,	6,	1,	do_onenand,
> +	"onenand - OneNAND sub-system\n",
> +	"info   - show available OneNAND devices\n"
> +	"onenand read[.oob] addr ofs len - read data at ofs with len to addr\n"
> +	"onenand write addr ofs len - write data at ofs with len from addr\n"
> +	"onenand erase saddr eaddr - erase block start addr to end addr\n"
> +	"onenand block[.oob] addr block [page] [len] - "
> +	"read data with (block [, page]) to addr\n"

Sorry for the nitpicking, but I recommend to make this:

> +	"onenand erase saddr eaddr - erase block start addr to end addr\n"
> +	"onenand block[.oob] addr block [page] [len] - "
> +		"read data with (block [, page]) to addr\n"

so it's clearly visible what that will look like. You may even use an
explicit continuation mark (trailing backslash) on the line before,
even though it's not necessary - just as a reminder for the reader.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unsichtbar macht sich die Dummheit, indem sie immer  gr??ere  Ausma?e
annimmt.                             -- Bertold Brecht: Der Tui-Roman