public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] MIPS cache management (and build) questions.
Date: Thu, 13 Sep 2007 09:38:49 +0200	[thread overview]
Message-ID: <200709130938.49606.sr@denx.de> (raw)
In-Reply-To: <760873.90830.qm@web54005.mail.re2.yahoo.com>

Hi Paul,

On Thursday 13 September 2007, Paul Marciano wrote:
> 2. I'm using do_bootelf() to invoke my image.  The
> lines:
>     addr = load_elf_image(addr);
>     ...
>     if (dcache_status())
>         dcache_disable();
>     ...
>     (function call through addr)
>
> The comment embedded in the code says the dcache is
> flushed already, but in cpu/mips/cpu.c, the function
> flush_cache() is empty so the dcache isn't flushed.
>
> As it's not flushed, and dcache_disable() just turns
> it off, if the run address is somewhere that hasn't
> naturally spilled out of the dcache during the load,
> the CPU will fetch garbage.

On PPC platforms, dcache_disable() first flushed the dcache and then disables 
it. If this flushing is missing in your MIPS implementation you should 
probably add this.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2007-09-13  7:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-13  7:26 [U-Boot-Users] MIPS cache management (and build) questions Paul Marciano
2007-09-13  7:38 ` Stefan Roese [this message]
2007-09-13  9:54 ` Shinya Kuribayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709130938.49606.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox