public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] PATCH - Fix oob data copied into supplied buffer
Date: Sun, 23 Sep 2007 01:03:26 +0200	[thread overview]
Message-ID: <20070922230326.188F224811@gemini.denx.de> (raw)
In-Reply-To: Your message of "Thu, 20 Sep 2007 19:15:40 PDT." <46F3294C.2030206@boundarydevices.com>

In message <46F3294C.2030206@boundarydevices.com> you wrote:
>
> > First chunk fixes a minor spelling error. Then I can't understand why
> > introduce a new variable. Everything works fine with existing structures 
> > and
> > it's been like this for ages, both in Linux kernel and U-Boot.
> > 
> If you look at the kernel, you'll see that oobavail is set there the way I did it.
> The other bug doesn't show up unless you have multiple oobfree groups. The new variable
> is used when reading or writing pages that an initial program loader reads. It's purpose
> is to correct pages without using a bad block table. I'll submit that code if this is approved.

kis's comments were legitimate.

Please add this variable only when adding code that uses it. I will
always reject patches that attempt to add unused code or variables.

Also, please describe *all* your changes.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
About the use of language: it is impossible to sharpen a pencil  with
a  blunt  ax.  It is equally vain to try to do it with ten blunt axes
instead.                                           -- Edsger Dijkstra

  reply	other threads:[~2007-09-22 23:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21  0:24 [U-Boot-Users] PATCH - Fix oob data copied into supplied buffer Troy Kisky
2007-09-21  1:33 ` ksi at koi8.net
2007-09-21  2:15   ` Troy Kisky
2007-09-22 23:03     ` Wolfgang Denk [this message]
2007-09-24 23:41       ` Troy Kisky
2008-04-21  6:46         ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070922230326.188F224811@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox