public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [MIPS] Fix toolchain restriction for little endian build
Date: Mon, 24 Sep 2007 22:44:44 +0200	[thread overview]
Message-ID: <20070924204444.74A8324769@gemini.denx.de> (raw)
In-Reply-To: Your message of "Tue, 25 Sep 2007 00:44:07 +0900." <46F7DB47.8030706@ruby.dti.ne.jp>

Dear Shinya Kuribayashi,

in message <46F7DB47.8030706@ruby.dti.ne.jp> you wrote:
> Fix ENDIANNESS condition to allow gcc toolchains other than ELDK.
> 
> Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>

Thanks you very much for your patch.

> -ifneq (,$(findstring 4KCle,$(CROSS_COMPILE)))
> +ifneq (,$(shell $(CC) -dumpmachine |grep 'mips.*el-.*'))
>  ENDIANNESS = -EL
>  else
>  ENDIANNESS = -EB

I'm afraid I don't understand how this is supposed to work.
For example, I get this using ELDK 4.x:

	-> export CROSS_COMPILE=mips_4KC-
	-> mips_4KC-gcc -dumpmachine
	mips-linux
	-> export CROSS_COMPILE=mips_4KCle-
	-> mips_4KCle-gcc -dumpmachine
	mips-linux
	-> 

So this change might work with other toolchains (I'm not sure if it
does), but it definitely breaks ELDK support.

Am I missing something?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A day without sunshine is like night.

      reply	other threads:[~2007-09-24 20:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-24 15:44 [U-Boot-Users] [MIPS] Fix toolchain restriction for little endian build Shinya Kuribayashi
2007-09-24 20:44 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070924204444.74A8324769@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox