From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] M18 flash (Sibley) support (attempt 2)
Date: Fri, 28 Sep 2007 18:40:04 +0200 [thread overview]
Message-ID: <20070928164004.30D1C24769@gemini.denx.de> (raw)
In-Reply-To: Your message of "Fri, 28 Sep 2007 19:47:24 +0400." <202cde0e0709280847r26684293yd0b9039c8254b75b@mail.gmail.com>
Dear Alexey,
in message <202cde0e0709280847r26684293yd0b9039c8254b75b@mail.gmail.com> you wrote:
>
> > > -static void flash_make_cmd (flash_info_t * info, uchar cmd, void *cmdbuf);
> > > -static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd);
> > > +static void flash_make_cmd (flash_info_t * info, ulong cmd, void *cmdbuf);
> > > +static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset, ulong cmd);
...
> > I don't see any differences here. Why is this flagged as a change?
> The difference is in type of "cmd" variable.
Argh. You are right. Sorry for the noise.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"To take a significant step forward, you must make a series of finite
improvements." - Donald J. Atwood, General Motors
next prev parent reply other threads:[~2007-09-28 16:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 11:29 [U-Boot-Users] [PATCH] M18 flash (Sibley) support (attempt 2) Vasiliy Leoenenko
2007-09-28 14:47 ` Wolfgang Denk
2007-09-28 15:47 ` Alexey Korolev
2007-09-28 16:40 ` Wolfgang Denk [this message]
2008-04-21 7:02 ` Stefan Roese
2008-04-23 9:42 ` Vasiliy Leoenenko
2008-04-25 6:35 ` Stefan Roese
2008-04-29 12:14 ` Vasiliy Leoenenko
2008-04-29 13:02 ` Jean-Christophe PLAGNIOL-VILLARD
2008-04-29 12:15 ` Vasiliy Leoenenko
2008-04-29 12:43 ` Stefan Roese
2008-04-29 13:43 ` Wolfgang Denk
2008-04-29 14:39 ` Vasiliy Leoenenko
2008-04-29 14:40 ` Vasiliy Leoenenko
2008-04-29 15:03 ` Anatolij Gustschin
2008-05-07 17:23 ` Vasiliy Leoenenko
2008-05-07 17:24 ` Vasiliy Leoenenko
2008-06-03 19:07 ` Stefan Roese
2008-05-07 17:25 ` Vasiliy Leoenenko
2008-06-03 19:07 ` Stefan Roese
2008-05-07 18:05 ` Vasiliy Leoenenko
2008-05-12 9:36 ` Vasiliy Leonenko
2008-05-13 5:42 ` Stefan Roese
2008-04-29 14:40 ` Vasiliy Leoenenko
2008-04-29 12:16 ` Vasiliy Leoenenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928164004.30D1C24769@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox