public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] Add definition of SA1110 register for PXA2xx processors.
@ 2007-10-02  5:17 Thierry Reding
  2007-10-02  5:43 ` Wolfgang Denk
  0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2007-10-02  5:17 UTC (permalink / raw)
  To: u-boot

This patch adds the SA1110 register definition for PXA2xx processors. I could
only get my hands on a PXA27x developer's manual, but I'm assuming the
register is available on previous generations as well. If not it should be
moved into a CONFIG_PXA27X section.

Cheers,
Thierry

---

 include/asm-arm/arch-pxa/pxa-regs.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/asm-arm/arch-pxa/pxa-regs.h b/include/asm-arm/arch-pxa/pxa-regs.h
index 9b4da3a..099db5a 100644
--- a/include/asm-arm/arch-pxa/pxa-regs.h
+++ b/include/asm-arm/arch-pxa/pxa-regs.h
@@ -2211,6 +2211,7 @@ typedef void		(*ExcpHndlr) (void) ;
 #define MCIO1		__REG(0x4800003C)  /* Card interface I/O Space Socket 1 Timing Configuration */
 #define MDMRS		__REG(0x48000040)  /* MRS value to be written to SDRAM */
 #define BOOT_DEF	__REG(0x48000044)  /* Read-Only Boot-Time Register. Contains BOOT_SEL and PKG_SEL */
+#define SA1110		__REG(0x48000064)  /* Static Memory SA-1110 Compatibility Configuration Register */
 
 #define MDREFR_K2FREE	(1 << 25)	/* SDRAM Free-Running Control */
 #define MDREFR_K1FREE	(1 << 24)	/* SDRAM Free-Running Control */

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot-Users] [PATCH] Add definition of SA1110 register for PXA2xx processors.
  2007-10-02  5:17 [U-Boot-Users] [PATCH] Add definition of SA1110 register for PXA2xx processors Thierry Reding
@ 2007-10-02  5:43 ` Wolfgang Denk
  2007-10-02  6:51   ` Thierry Reding
  0 siblings, 1 reply; 4+ messages in thread
From: Wolfgang Denk @ 2007-10-02  5:43 UTC (permalink / raw)
  To: u-boot

In message <20071002051753.16402.86018.stgit@avionic-0027.adnet.avionic-design.de> you wrote:
> This patch adds the SA1110 register definition for PXA2xx processors. I could
> only get my hands on a PXA27x developer's manual, but I'm assuming the
> register is available on previous generations as well. If not it should be
> moved into a CONFIG_PXA27X section.

Who needs this register?  Seems  all  existing  U-Boot  code  can  do
without it?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This is an unauthorized cybernetic announcement.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot-Users] [PATCH] Add definition of SA1110 register for PXA2xx processors.
  2007-10-02  5:43 ` Wolfgang Denk
@ 2007-10-02  6:51   ` Thierry Reding
  2007-10-02  7:18     ` Wolfgang Denk
  0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2007-10-02  6:51 UTC (permalink / raw)
  To: u-boot

* Wolfgang Denk wrote:
> In message <20071002051753.16402.86018.stgit@avionic-0027.adnet.avionic-design.de> you wrote:
> > This patch adds the SA1110 register definition for PXA2xx processors. I could
> > only get my hands on a PXA27x developer's manual, but I'm assuming the
> > register is available on previous generations as well. If not it should be
> > moved into a CONFIG_PXA27X section.
> 
> Who needs this register?  Seems  all  existing  U-Boot  code  can  do
> without it?

We use this register in some of our boards. I was planning to submit patches
with the board-specific code sometime later so I thought it was a good idea
to send this in before.

> Best regards,
> 
> Wolfgang Denk

Cheers,
Thierry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20071002/622d2ff1/attachment.pgp 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot-Users] [PATCH] Add definition of SA1110 register for PXA2xx processors.
  2007-10-02  6:51   ` Thierry Reding
@ 2007-10-02  7:18     ` Wolfgang Denk
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2007-10-02  7:18 UTC (permalink / raw)
  To: u-boot

In message <20071002065111.GA27564@avionic-tr-basi.adnet.avionic-design.de> you wrote:
> 
> > Who needs this register?  Seems  all  existing  U-Boot  code  can  do
> > without it?
> 
> We use this register in some of our boards. I was planning to submit patches
> with the board-specific code sometime later so I thought it was a good idea
> to send this in before.

Please include it with the patches that use it, then.

I don't want to add unused code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Doubt is a pain too lonely to know that faith is his twin brother.
- Kahlil Gibran

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-10-02  7:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-02  5:17 [U-Boot-Users] [PATCH] Add definition of SA1110 register for PXA2xx processors Thierry Reding
2007-10-02  5:43 ` Wolfgang Denk
2007-10-02  6:51   ` Thierry Reding
2007-10-02  7:18     ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox