From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fixed pcnet io_base , added Am79C970A chip id
Date: Wed, 10 Oct 2007 20:36:36 +0200 [thread overview]
Message-ID: <20071010183636.47EC52486E@gemini.denx.de> (raw)
In-Reply-To: Your message of "Wed, 10 Oct 2007 13:25:42 +0300." <470CA8A6.5060900@comsys.ro>
In message <470CA8A6.5060900@comsys.ro> you wrote:
> Bus and phys address are not always the same
OK, so this would be a bug fix.
> --- a/drivers/pcnet.c
> +++ b/drivers/pcnet.c
> @@ -196,6 +196,7 @@ int pcnet_initialize(bd_t *bis)
> * Setup the PCI device.
> */ pci_read_config_dword(devbusfn, PCI_BASE_ADDRESS_0, (unsigned int *)&dev->iobase);
> + dev->iobase=pci_io_to_phys(devbusfn,dev->iobase);
Here it goes.
> @@ -260,6 +261,9 @@ static int pcnet_probe(struct eth_device* dev, bd_t *bis, int dev_nr)
> return -1;
> chip_version = (chip_version >> 12) & 0xffff;
> switch (chip_version) {
> + case 0x2621:
> + chipname = "PCnet/PCI II 79C970A"; /* PCI */
> + break;
But this is new code and completely unrelated to the bug fix.
Please split and submit as two separate patched - the first will go
into 1.3.0, the second will have to wait.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you want strict real-time behavior, run in the real time schedu-
ling class. But there are no seatbelts or airbags; main(){for(;;);}
can hard hang your system. -- Bart Smaalders
prev parent reply other threads:[~2007-10-10 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 10:25 [U-Boot-Users] [PATCH] Fixed pcnet io_base , added Am79C970A chip id Vlad Lungu
2007-10-10 18:36 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010183636.47EC52486E@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox