From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Date: Mon, 15 Oct 2007 13:20:17 +1000 Subject: [U-Boot-Users] libfdt release? In-Reply-To: <470F1F31.7060802@grandegger.com> References: <006E3CAD-11CB-4892-8BDB-9866677F371D@freescale.com> <20071010061458.GA6135@localhost.localdomain> <912BB32E-FD7D-4CBC-AE3D-3D358E97DECB@freescale.com> <20071011041239.GF14873@localhost.localdomain> <9917D225-2082-4900-BFD4-96490EA88C42@freescale.com> <470EB351.4070009@gmail.com> <20071012042811.GK21056@localhost.localdomain> <470F1F31.7060802@grandegger.com> Message-ID: <20071015032017.GH14108@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Oct 12, 2007 at 09:16:01AM +0200, Wolfgang Grandegger wrote: > David Gibson wrote: > >On Thu, Oct 11, 2007 at 07:35:45PM -0400, Jerry Van Baren wrote: > >[snip] > >>>>>* Replace fdt_node_offset() with fdt_find_node_by_path(). > >>>>There is no fdt_node_offset(), fdt_path_offset() they mean, maybe. > >>>>And why a gratuitous name change...? > >>>Jerry? > >>We needed the function (Detlev, IIRC). The gratuitous name change was > >>intended to be more descriptive. Perhaps if the correct original name > >>were used, we wouldn't have needed a gratuitous name change. ;-) > > > >Heh. > > > >Do bear in mind in future that the naming conventions in libfdt aren't > >arbitrary. I've tried to put "offset" in the name of everything that > >returns a structure block offset as a hint to that return convention. > >Additionally it's supposed to mitigate the big libfdt gotcha - that > >offsets aren't handles, so the offset for a node can change if you > >alter another node. > > I proposed the name change some time ago on this list: > > http://sourceforge.net/mailarchive/forum.php?thread_name=4639F61F.2050506%40grandegger.com&forum_name=u-boot-users > > And they have been accepted and nobody complained ;-). Well, of course not; I'm not on the u-boot list. > The main reason > for the change was to make them (almost) compatible with the names used > by Linux. I think that's useful when we start using FDT for configuring > U-Boot. Well, you have my reasons for *not* doing that, above. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson