[U-Boot-Users] [PATCH] PPC4xx: Add Ethernet 1000BASE-X support for PPC4xx

[Wolfgang Denk <wd@denx.de>]

In message <47262967.8070307@arlinx.com> you wrote:
>
> Would it be better to run Lindent on the original files, post those as
> changes, and then post a second patch with the new material?

If it's your code, or other original code, then yes, this is the way
to go.

But if it's code that was "borrowed" from somewhere else  (like  from
the  Linux  kernel, busybox, etc.) and then only slightly modified to
make it work under U-Boot, then please *DO*  *NOT*  reformat  it,  as
this basicly makes it impossible to update the file from new versions
of the original code.

> BTW, I've noticed that the "Lindent -pcs" format is used inconsistently
> within files.  Since I'm also making changes in Linux, it's hard to
> remember whether to type "foo(bar);" or "foo (bar);", maybe others have
> this difficulty, too.  I've tried to use the form that is prevalent in
> each individual file, though some are pretty much split down the middle.
> 
> How do others feel?

It should be "foo (bar)".

And all this should be sufficiently documented at
http://www.denx.de/wiki/UBoot/CodingStyle

If you feel that details are missing or not  clear  enought  in  this
text please help to extend / fix it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I distrust all systematisers, and avoid them. The will  to  a  system
shows a lack of honesty.
- Friedrich Wilhelm Nietzsche _G?tzen-D?mmerung [The Twilight of  the
Idols]_ ``Maxims and Missiles'' no. 26