From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 30 Oct 2007 21:09:16 +0100 Subject: [U-Boot-Users] [PATCH 1/2] PPC4xx: Cosmetic changes In-Reply-To: <47274021.6080605@arlinx.com> References: <47274021.6080605@arlinx.com> Message-ID: <200710302109.17124.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Larry, On Tuesday 30 October 2007, Larry Johnson wrote: > Signed-off-by: Larry Johnson > --- > > common/miiphyutil.c | 141++++++++++++++++++++++++-------------------------- > cpu/ppc4xx/miiphy.c | 58 +++++++-------------- > include/miiphy.h | 92 +++++++++++++++------------------ > 3 files changed, 130 insertions(+), 161 deletions(-) It is a little problematic, if you combine patches for a "common" networking file like common/miiphyutil.c and board/platform specific code in one patch. This is because one should get picked up by the networking custodian (Ben Warren) and the other by myself. I see that both changes belong together, but you should nevertheless split them up into separate patches. Same holds for the next patch of course too. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================