public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2 (resubmit)] NET: Cosmetic changes
Date: Sat, 03 Nov 2007 22:56:52 +0100	[thread overview]
Message-ID: <20071103215652.6DCC724756@gemini.denx.de> (raw)
In-Reply-To: Your message of "Wed, 31 Oct 2007 11:21:29 EST." <4728AB89.80205@arlinx.com>

In message <4728AB89.80205@arlinx.com> you wrote:
> -	int (* read)(char *devname, unsigned char addr,
> -			unsigned char reg, unsigned short *value);
> -	int (* write)(char *devname, unsigned char addr,
> -			unsigned char reg, unsigned short value);

The old code used TAB for indentation. Good.

> +	int (*read) (char *devname, unsigned char addr,
> +		     unsigned char reg, unsigned short *value);
> +	int (*write) (char *devname, unsigned char addr,
> +		      unsigned char reg, unsigned short value);

Now you add to the file size by indeting with characters which is,
strictly speaking, a violation of the Coding Style).


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have yet to add the ESP-driver to the kernel to read  the  mind  of
the user...                                       - Linus Torvalds in
      <Pine.LNX.3.91.960426110644.24860I-100000@linux.cs.Helsinki.FI>

  reply	other threads:[~2007-11-03 21:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31 16:21 [U-Boot-Users] [PATCH 1/2 (resubmit)] NET: Cosmetic changes Larry Johnson
2007-11-03 21:56 ` Wolfgang Denk [this message]
2007-11-04 23:27   ` Larry Johnson
2007-11-05  5:45     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071103215652.6DCC724756@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox