From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 5 Nov 2007 06:45:53 +0100 Subject: [U-Boot-Users] [PATCH 1/2 (resubmit)] NET: Cosmetic changes In-Reply-To: <472E5573.70500@arlinx.com> References: <20071103215652.6DCC724756@gemini.denx.de> <472E5573.70500@arlinx.com> Message-ID: <200711050645.53687.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 05 November 2007, Larry Johnson wrote: > Wolfgang Denk wrote: > > In message <4728AB89.80205@arlinx.com> you wrote: > >> - int (* read)(char *devname, unsigned char addr, > >> - unsigned char reg, unsigned short *value); > >> - int (* write)(char *devname, unsigned char addr, > >> - unsigned char reg, unsigned short value); > > > > The old code used TAB for indentation. Good. > > > >> + int (*read) (char *devname, unsigned char addr, > >> + unsigned char reg, unsigned short *value); > >> + int (*write) (char *devname, unsigned char addr, > >> + unsigned char reg, unsigned short value); > > > > Now you add to the file size by indeting with characters which is, > > strictly speaking, a violation of the Coding Style). > > > > > > Best regards, > > > > Wolfgang Denk > > Hi Wolfgang, > > Unfortunately, it was "Lindent" that broke the indentation. Apparently, > when a parameter list to a function call doesn't fit on a line, it tries > to line up additional parameters beneath the first one. Right. And this is exactly the style I prefer too (and my emacs ;)). > I could search for and fix these cases, but it would defeat the purpose > of posting these cosmetic changes, which was so that the next time > someone uses "Lindent" on the file to check modifications, he or she > won't get a bunch of changes to the unmodified parts of the code. I vote for accepting this patch (and others with this indentation style), since it's a common used pratice. And as Larry explained, even Lindent uses it by default. We shouldn't dictate each and every bit, how sourcecode should be layouted. A little bit of personal freedom should be possible here. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================