[U-Boot-Users] EABI Problem

Wolfgang Denk
2007-11-05T19:26:25Z

In message <20071105161853.GA28049@sig21.net> you wrote:
>
> So I now only need two tiny patches:
>
> ---
> fix warning: "warning: target CPU does not support interworking"
> when compiling with CodeSourcery gcc-4.2.1/binutils-2.18.50
>
> diff -ruNp u-boot-1.3.0-rc3/cpu/arm920t/config.mk u-boot-1.3.0-rc3.my/cpu/arm920t/config.mk
> --- u-boot-1.3.0-rc3/cpu/arm920t/config.mk 2007-10-14 00:13:19.000000000 +0200
> +++ u-boot-1.3.0-rc3.my/cpu/arm920t/config.mk 2007-11-05 14:31:19.000000000 +0100
> @@ -24,7 +24,7 @@
> PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-common -ffixed-r8 \
> -msoft-float
>
> -PLATFORM_CPPFLAGS += -march=armv4
> +PLATFORM_CPPFLAGS += -march=armv4t

Has this change been verified by anybody using another toolchain?

> ---
> fix compile error: "start.S:205: Error: invalid constant (20200) after fixup"
>
> diff -ruNp u-boot-1.3.0-rc3/include/configs/kb9202.h u-boot-1.3.0-rc3.my/include/configs/kb9202.h
> --- u-boot-1.3.0-rc3/include/configs/kb9202.h 2007-10-14 00:13:19.000000000 +0200
> +++ u-boot-1.3.0-rc3.my/include/configs/kb9202.h 2007-11-05 14:37:17.000000000 +0100
> @@ -57,7 +57,7 @@
> /*
> * Size of malloc() pool
> */
> -#define CFG_MALLOC_LEN (CFG_ENV_SIZE + 128*1024)
> +#define CFG_MALLOC_LEN (128*1024)

This is definitely a bad change; reducing the size of thje malloc
area below what is actually needed is not a good ide. Also, I don't
see why this change would be needed. If there is a compi8le problem,
the reason for that problem should be located and fixed, without
changing this code.

This is a definitve NAK for this change, as it fixzes the symptoms
while leaving the problem unfixed.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are two ways to write error-free programs. Only the third one
works.