From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 6 Nov 2007 09:59:28 +0100 Subject: [U-Boot-Users] Mixing CFI and non-CFI flashs? In-Reply-To: <20071106082639.GA18904@discworld.dascon.de> References: <472B8E46.7000808@discworld.dascon.de> <200711060848.39359.sr@denx.de> <20071106082639.GA18904@discworld.dascon.de> Message-ID: <200711060959.28435.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 06 November 2007, Michael Schwingen wrote: > > Wouldn't it be better not to remove those unused fields? This way porting > > of new devices from Linux to U-Boot would be easier. > > Right. I was concerned about the size of the table - the complete table > from Linux contains *lots* of devices and may take up quite some space, so > stripping out unused fields should help a bit. If there is a consensus to > keep the fields to ease porting new parts, that is fine with me. I vote for keeping the fields in. From my point of view, it's better to only enable a small part of the available FLASH definitions, than to strip some fields from the struct and make porting more difficult. > I think in the future we may need some ifdefs in the table to select > sub-sets of supported parts - if a board has a 29LV040, it is useful to > have support for other flash ROMS with similar layout and pinout that may > be used as alternatives, but completely different parts (eg. 29LV160) may > be left out. ACK. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================