[U-Boot-Users] Compilation warning in common/cmd_ide.c

[U-Boot-Users] Compilation warning in common/cmd_ide.c

[Stefan Roese]

Hi Marcel,

Commit 2a4741d9a14ec475f50e9856d2c0a67e8b4271bd "[PATCH] fix pxa255_idp board"
maybe fixes a problem on ARM boards, but unfortunately introduces a
compile warning on PPC platforms like CPCI405:

cmd_ide.c: In function 'ide_ident':
cmd_ide.c:1139: warning: pointer targets in passing argument 1 of 'ident_cpy' differ in signedness
cmd_ide.c:1140: warning: pointer targets in passing argument 1 of 'ident_cpy' differ in signedness
cmd_ide.c:1141: warning: pointer targets in passing argument 1 of 'ident_cpy' differ in signedness

I'm wondering if you see this warning on your ARM platform too. Could
you please recheck and perhaps revert this patch? Is this change in part.h
really needed? Does it fix an existing problem?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] Compilation warning in common/cmd_ide.c

[Jean-Christophe PLAGNIOL-VILLARD]

On 10:49 Wed 07 Nov     , Stefan Roese wrote:
> Hi Marcel,
> 
> Commit 2a4741d9a14ec475f50e9856d2c0a67e8b4271bd "[PATCH] fix pxa255_idp board"
> maybe fixes a problem on ARM boards, but unfortunately introduces a
> compile warning on PPC platforms like CPCI405:
> 
> cmd_ide.c: In function 'ide_ident':
> cmd_ide.c:1139: warning: pointer targets in passing argument 1 of 'ident_cpy' differ in signedness
> cmd_ide.c:1140: warning: pointer targets in passing argument 1 of 'ident_cpy' differ in signedness
> cmd_ide.c:1141: warning: pointer targets in passing argument 1 of 'ident_cpy' differ in signedness
> 
> I'm wondering if you see this warning on your ARM platform too. Could
> you please recheck and perhaps revert this patch? Is this change in part.h
> really needed? Does it fix an existing problem?
> 
> Best regards,
> Stefan

I will send a patch about it within 4h.

Best regards,
J.

> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] Compilation warning in common/cmd_ide.c

[Marcel Ziswiler]

Hi Stefan

> Commit 2a4741d9a14ec475f50e9856d2c0a67e8b4271bd "[PATCH] fix pxa255_idp board"
> maybe fixes a problem on ARM boards, but unfortunately introduces a
> compile warning on PPC platforms.

Sorry but it seems my fix just moved the compilation warning from
showing up on ARM to now crop up on PPC platforms.

J's patch with Message-ID:
<1194419961-21822-1-git-send-email-plagnioj@jcrosoft.com> is the right
fix and I verified it on my ARM boards.
A great thank you to J for providing the right fix and doing it so
quickly.

Cheers

Marcel

PS: I am now working my way through William Juul's latest NAND updates
to get your nand_spl working on big block NANDs on PXA3xx as well.

[U-Boot-Users] Compilation warning in common/cmd_ide.c

[Stefan Roese]

Hi Marcel,

On Wednesday 07 November 2007, Marcel Ziswiler wrote:
> > Commit 2a4741d9a14ec475f50e9856d2c0a67e8b4271bd "[PATCH] fix pxa255_idp
> > board" maybe fixes a problem on ARM boards, but unfortunately introduces
> > a compile warning on PPC platforms.
>
> Sorry but it seems my fix just moved the compilation warning from
> showing up on ARM to now crop up on PPC platforms.
>
> J's patch with Message-ID:
> <1194419961-21822-1-git-send-email-plagnioj@jcrosoft.com> is the right
> fix and I verified it on my ARM boards.
> A great thank you to J for providing the right fix and doing it so
> quickly.

Yes, thanks.

> Cheers
>
> Marcel
>
> PS: I am now working my way through William Juul's latest NAND updates
> to get your nand_spl working on big block NANDs on PXA3xx as well.

OK. I am looking at the new NAND code right now too. Comments will follow 
soon.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================