From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] RFC: Some improvements for the FPGA subsystem
Date: Mon, 12 Nov 2007 15:51:29 +0100 [thread overview]
Message-ID: <200711121551.30108.matthias.fuchs@esd-electronics.com> (raw)
In-Reply-To: <47385408.3040106@ge.com>
Hi Jerry,
On Monday 12 November 2007 14:24, Jerry Van Baren wrote:
> > - char val;
> > + unsigned char val;
>
> Trivia: This change should not be necessary since you fixed the
> conditional (below) to do a bit-wise & 0x80 rather than a signed compare
> that has portability and aesthetic problems.
yes, of course.
> > val = data [bytecount ++];
But since the right value is an unsigned char, I like the left value
to be of the same type.
> Painting the bike shed blue,
We should ask the others that are involved ins discussion if blue might
bring disadvantages :-)
Matthias
next prev parent reply other threads:[~2007-11-12 14:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 16:45 [U-Boot-Users] RFC: Some improvements for the FPGA subsystem Matthias Fuchs
2007-11-12 0:17 ` Grant Likely
2007-11-12 9:15 ` w.wegner at astro-kom.de
2007-11-12 9:45 ` Matthias Fuchs
2007-11-12 10:06 ` w.wegner at astro-kom.de
2007-11-12 13:24 ` Jerry Van Baren
2007-11-12 14:51 ` Matthias Fuchs [this message]
2007-11-12 15:00 ` Jerry Van Baren
2007-12-10 12:04 ` w.wegner at astro-kom.de
2007-12-11 17:00 ` Matthias Fuchs
2007-12-12 10:44 ` w.wegner at astro-kom.de
2007-12-13 9:23 ` Matthias Fuchs
2007-11-12 22:55 ` Bruce_Leonard at selinc.com
2007-11-12 23:09 ` Grant Likely
2007-11-13 8:34 ` Matthias Fuchs
2007-11-13 18:15 ` Bruce_Leonard at selinc.com
2007-11-14 7:56 ` Matthias Fuchs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711121551.30108.matthias.fuchs@esd-electronics.com \
--to=matthias.fuchs@esd-electronics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox