From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
Date: Mon, 12 Nov 2007 15:51:29 +0100
Subject: [U-Boot-Users] RFC: Some improvements for the FPGA subsystem
In-Reply-To: <47385408.3040106@ge.com>
References: <200711111745.02822.matthias.fuchs@esd-electronics.com>
	<47385408.3040106@ge.com>
Message-ID: <200711121551.30108.matthias.fuchs@esd-electronics.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Jerry,

On Monday 12 November 2007 14:24, Jerry Van Baren wrote:
> > -	char  val;
> > +	unsigned char val;
> 
> Trivia: This change should not be necessary since you fixed the 
> conditional (below) to do a bit-wise & 0x80 rather than a signed compare 
> that has portability and aesthetic problems.
yes, of course.

> >  			val = data [bytecount ++];
But since the right value is an unsigned char, I like the left value
to be of the same type.

> Painting the bike shed blue,
We should ask the others that are involved ins discussion if blue might
bring disadvantages :-)

Matthias